fix(integration-tests): Java TPH harness coerces the enum-typed @Discriminator

release-gate (java) was failing (uncovered once the Maven dep-resolution fix let
it actually run): TphGeneratedApiContractConformanceTest's generated sources failed
to compile with "String cannot be converted to AuthDto.AuthType". Proven pre-existing
(reproduces with the pre-FR-019 generator) — the TPH api-contract fixture's `type`
discriminator is a field.enum, so the generated AuthDto types it as the AuthType enum
(the cross-port typed-enum contract), but the Java test scaffolding still assumed a
String-typed discriminator. Kotlin's release-gate passed because its harness seeds via
HTTP POST (discriminator from the URL) and never constructs a DTO with the raw String.

Bring the Java harness/scaffolding in line with the enum-typed discriminator:
- GeneratedTphControllerHarness: resolve the generated nested AuthType reflectively,
  bind the ctor with it, and coerce the seed's String `type` via Enum.valueOf.
- InMemoryAuthRepositorySource: coerce the URL discriminator with AuthType.valueOf
  on create, and compare via a.type().name() (String-vs-enum equality was silently
  always-false, which would have broken per-subtype scoping).

TphGeneratedApiContractConformanceTest now 5/0 locally (in-process MockMvc, no docker).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: dmealing

server/java/integration-tests/src/test/java/com/metaobjects/integration/api/tph/generated/GeneratedTphControllerHarness.java

@@ -72,7 +72,8 @@ public final class GeneratedTphControllerHarness implements AutoCloseable {
 
     private final ObjectMapper mapper = new ObjectMapper();
     private final URLClassLoader classLoader;
-    private final Constructor<?> dtoCtor;        // (Long id, String type, String reference, Integer quantity, BigDecimal copayAmount, String approver)
+    private final Constructor<?> dtoCtor;        // (Long id, AuthType type, String reference, Integer quantity, BigDecimal copayAmount, String approver)
+    private final Class<?> authTypeClass;        // the generated value-constrained enum discriminator (AuthDto.AuthType)
     private final Constructor<?> controllerCtor; // (AuthRepository)
     private final Constructor<?> repoCtor;       // (List<AuthDto> seed)
     private final List<Map<String, Object>> seedRows;
@@ -109,8 +110,11 @@ public GeneratedTphControllerHarness(Path corpusRoot, Path genDir, List<Map<Stri
         // 5. Load the compiled classes (child of the test loader so Spring + runtime types resolve).
         this.classLoader = new URLClassLoader(new URL[]{ classesDir.toUri().toURL() }, getClass().getClassLoader());
         Class<?> dtoClass = classLoader.loadClass(DTO_FQCN);
+        // `type` is the value-constrained enum discriminator (field.enum): the generated DTO ctor
+        // takes the nested AuthType, not String. Resolve the enum reflectively to build seed rows.
+        this.authTypeClass = classLoader.loadClass(DTO_FQCN + "$AuthType");
         this.dtoCtor = dtoClass.getDeclaredConstructor(
-            Long.class, String.class, String.class, Integer.class, BigDecimal.class, String.class);
+            Long.class, authTypeClass, String.class, Integer.class, BigDecimal.class, String.class);
         Class<?> repoInterface = classLoader.loadClass(REPO_FQCN);
         this.controllerCtor = classLoader.loadClass(CONTROLLER_FQCN).getDeclaredConstructor(repoInterface);
         this.repoCtor = classLoader.loadClass(InMemoryAuthRepositorySource.FQCN).getDeclaredConstructor(List.class);
@@ -162,7 +166,10 @@ private Object dtoFromRow(Map<String, Object> row) throws Exception {
         Object copayRaw = row.get("copayAmount");
         BigDecimal copayAmount = copayRaw == null ? null : new BigDecimal(String.valueOf(copayRaw));
         String approver = (String) row.get("approver");
-        return dtoCtor.newInstance(id, type, reference, quantity, copayAmount, approver);
+        // Coerce the seed's String discriminator into the generated AuthType enum value.
+        @SuppressWarnings({ "unchecked", "rawtypes" })
+        Object typeEnum = type == null ? null : Enum.valueOf((Class) authTypeClass, type);
+        return dtoCtor.newInstance(id, typeEnum, reference, quantity, copayAmount, approver);
     }
 
     private static MetaDataLoader loadCorpus(Path metaJson) {

server/java/integration-tests/src/test/java/com/metaobjects/integration/api/tph/generated/InMemoryAuthRepositorySource.java

@@ -85,22 +85,25 @@ public Optional<AuthDto> findById(Long id) {
             @Override
             public List<AuthDto> listByType(String discriminator, int limit, int offset, SortClause sort, List<FilterPredicate> filters) {
                 List<AuthDto> scoped = new ArrayList<>();
-                for (AuthDto a : rows) if (discriminator.equals(a.type())) scoped.add(a);
+                for (AuthDto a : rows) if (discriminator.equals(a.type().name())) scoped.add(a);
                 return page(sorted(filtered(scoped, filters), sort), limit, offset);
             }
 
             @Override
             public Optional<AuthDto> findByIdAndType(Long id, String discriminator) {
                 for (AuthDto a : rows)
-                    if (id.equals(a.id()) && discriminator.equals(a.type())) return Optional.of(a);
+                    if (id.equals(a.id()) && discriminator.equals(a.type().name())) return Optional.of(a);
                 return Optional.empty();
             }
 
             @Override
             public AuthDto createWithType(String discriminator, AuthDto dto) {
                 // Discriminator injected from the URL — dto.type() is intentionally ignored.
+                // `type` is a value-constrained enum (field.enum discriminator), so coerce the
+                // String URL discriminator into the generated AuthType (its members ARE the
+                // discriminator values).
                 AuthDto saved = new AuthDto(
-                    nextId.getAndIncrement(), discriminator, dto.reference(),
+                    nextId.getAndIncrement(), AuthDto.AuthType.valueOf(discriminator), dto.reference(),
                     dto.quantity(), dto.copayAmount(), dto.approver());
                 rows.add(saved);
                 return saved;
@@ -110,7 +113,7 @@ public AuthDto createWithType(String discriminator, AuthDto dto) {
             public Optional<AuthDto> updateByIdAndType(Long id, String discriminator, AuthDto dto) {
                 for (int i = 0; i < rows.size(); i++) {
                     AuthDto cur = rows.get(i);
-                    if (!id.equals(cur.id()) || !discriminator.equals(cur.type())) continue;
+                    if (!id.equals(cur.id()) || !discriminator.equals(cur.type().name())) continue;
                     // Partial patch; discriminator (type) and id are immutable.
                     AuthDto merged = new AuthDto(
                         id, cur.type(),
@@ -126,7 +129,7 @@ public Optional<AuthDto> updateByIdAndType(Long id, String discriminator, AuthDt
 
             @Override
             public boolean deleteByIdAndType(Long id, String discriminator) {
-                return rows.removeIf(a -> id.equals(a.id()) && discriminator.equals(a.type()));
+                return rows.removeIf(a -> id.equals(a.id()) && discriminator.equals(a.type().name()));
             }
 
             // --- helpers ---