Does not compile on Solaris

[neheb]

/export/home/mangix/devstuff/libkqueue/src/common/../solaris/../posix/eventfd.h:18:56: error: ‘struct filter’ declared inside parameter list [-Werror]
 int     posix_eventfd_init(struct eventfd *efd, struct filter *filt);

https://cfarm.tetaneutral.net/machines/list/ <-- gcc211

[neheb]

Seems it supports C11 atomics too.

[mheily]

Thanks for reporting this. I haven't attempted to compile libkqueue on Solaris in a long time, and I don't have a Solaris machine available for testing. I've submitted a request to the GCC Farm project to get an account.

[neheb]

A tip: the solaris 10 machine's ssh server doesn't support modern openssh. Might need to use dropbear instead of openssh to connect to it. Both Solaris 10 and 11 don't support ed25519 for keys.

[arr2036]

There's a solaris github actions recipe here: https://github.com/vmactions/solaris-vm

I'll see if I can add it to the standard set of builds and fix any outstanding issues.

[neheb]

current release:

 ../subprojects/libkqueue-2.6.2/src/common/../solaris/../posix/eventfd.h:18:56: warning: 'struct filter' declared inside parameter list will not be visible outside of this definition or declaration
     18 | int     posix_eventfd_init(struct eventfd *efd, struct filter *filt);
        |                                                        ^~~~~~
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c: In function 'kevent_dump':
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:148:14: error: 'u_int' undeclared (first use in this function); did you mean 'int'?
    148 |             (u_int) kev->ident,
        |              ^~~~~
        |              int
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:148:14: note: each undeclared identifier is reported only once for each function it appears in
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:148:20: error: expected ')' before 'kev'
    148 |             (u_int) kev->ident,
        |                    ^~~~
        |                    )
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:146:13: note: to match this '('
    146 |     snprintf((char *) buf, sizeof(buf),
        |             ^
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:142:34: warning: unused parameter 'kev' [-Wunused-parameter]
    142 | kevent_dump(const struct kevent *kev)
        |             ~~~~~~~~~~~~~~~~~~~~~^~~
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c: At top level:
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:111:1: warning: 'kevent_flags_dump' defined but not used [-Wunused-function]
    111 | kevent_flags_dump(const struct kevent *kev)
        | ^~~~~~~~~~~~~~~~~
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:38:1: warning: 'kevent_fflags_dump' defined but not used [-Wunused-function]
     38 | kevent_fflags_dump(const struct kevent *kev)
        | ^~~~~~~~~~~~~~~~~~
  ../subprojects/libkqueue-2.6.2/src/common/kevent.c:28:1: warning: 'kevent_filter_dump' defined but not used [-Wunused-function]
     28 | kevent_filter_dump(const struct kevent *kev)
        | ^~~~~~~~~~~~~~~~~~

edit: probably better to focus on https://github.com/vmactions/omnios-vm

[neheb]

--- a/.github/workflows/ci-freebsd.yml
+++ b/.github/workflows/ci-freebsd.yml
@@ -38,3 +38,20 @@ jobs:
           cmake .
           make
           ./libkqueue-test
+  omnios-tests:
+# virtualbox takes a long time to start
+    timeout-minutes: 15
+    runs-on: ubuntu-latest
+    name: "OmniOS tests"
+    steps:
+    - uses: actions/checkout@v4
+    - name: libkqueue test suite
+      uses: vmactions/omnios-vm@v1
+      with:
+        prepare: |
+          pkg install cmake gcc14 git
+        run: |
+          cd libkqueue/test
+          cmake .
+          make
+          ./libkqueue-test
diff --git a/CMakeLists.txt b/CMakeLists.txt
index a75a76a..f8a29eb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -287,6 +287,7 @@ if(WIN32)
 else()
   include(StdAtomicCheck)
   target_compile_definitions(objlib PRIVATE _XOPEN_SOURCE=600)
+  target_compile_definitions(objlib PRIVATE __EXTENSIONS__)
 endif()

 target_include_directories(objlib PRIVATE include)
diff --git a/src/common/kqueue.c b/src/common/kqueue.c
index c532258..abf5189 100644
--- a/src/common/kqueue.c
+++ b/src/common/kqueue.c
@@ -80,13 +80,12 @@ get_fd_limit(void)
 unsigned int
 get_fd_used(void)
 {
-    unsigned int fd_max = get_fd_limit();
-    unsigned int i;
     unsigned int used = 0;
     int our_errno = errno; /* Preserve errno */

 #ifdef __linux__
-    for (i = 0; i < fd_max; i++) {
+    unsigned int fd_max = get_fd_limit();
+    for (unsigned int i = 0; i < fd_max; i++) {
         if (fcntl(i, F_GETFD) == 0)
             used++;
     }
diff --git a/src/solaris/platform.h b/src/solaris/platform.h
index 105beba..be82203 100644
--- a/src/solaris/platform.h
+++ b/src/solaris/platform.h
@@ -25,6 +25,8 @@
 #include <sys/resource.h>
 #include <sys/time.h>

+struct filter;
+#include "../posix/platform_ext.h"
 #include "../posix/eventfd.h"

 /*

results in

  /home/runner/work/libkqueue/libkqueue/src/posix/eventfd.c: In function 'posix_eventfd_init':
  /home/runner/work/libkqueue/libkqueue/src/posix/eventfd.c:28:10: error: 'struct eventfd' has no member named 'ef_wfd'; did you mean 'ef_id'?
     28 |     efd->ef_wfd = sd[0];
        |          ^~~~~~
        |          ef_id
  /home/runner/work/libkqueue/libkqueue/src/posix/eventfd.c: In function 'posix_eventfd_close':
  /home/runner/work/libkqueue/libkqueue/src/posix/eventfd.c:43:16: error: 'struct eventfd' has no member named 'ef_wfd'; did you mean 'ef_id'?
     43 |     close(efd->ef_wfd);
        |                ^~~~~~
        |                ef_id
  /home/runner/work/libkqueue/libkqueue/src/posix/eventfd.c: In function 'posix_eventfd_raise':
  /home/runner/work/libkqueue/libkqueue/src/posix/eventfd.c:51:20: error: 'struct eventfd' has no member named 'ef_wfd'; did you mean 'ef_id'?
     51 |     if (write(efd->ef_wfd, ".", 1) < 0) {
        |                    ^~~~~~
        |                    ef_id