Convert int to string before contains check

Author: michael-rubel

src/Collection/Primitive/Boolean.php

@@ -42,14 +42,14 @@ class Boolean extends ValueObject
      *
      * @var array
      */
-    protected array $trueValues = ['1', 'true', 1, 'on', 'yes'];
+    protected array $trueValues = ['1', 'true', 'on', 'yes'];
 
     /**
      * Values that represent `false` boolean.
      *
      * @var array
      */
-    protected array $falseValues = ['0', 'false', 0, 'off', 'no'];
+    protected array $falseValues = ['0', 'false', 'off', 'no'];
 
     /**
      * Create a new instance of the value object.
@@ -83,9 +83,11 @@ public function value(): bool
      */
     protected function handleNonBoolean(int|string $value): void
     {
+        $string = is_string($value) ? $value : (string) $value;
+
         $this->value = match (true) {
-            Str::contains($value, $this->trueValues, ignoreCase: true) => true,
-            Str::contains($value, $this->falseValues, ignoreCase: true) => false,
+            Str::contains($string, $this->trueValues, ignoreCase: true) => true,
+            Str::contains($string, $this->falseValues, ignoreCase: true) => false,
             default => throw new InvalidArgumentException('Invalid boolean.'),
         };
     }

tests/Unit/Primitive/BooleanTest.php

@@ -11,6 +11,12 @@
     $this->assertTrue($valueObject->value());
 });
 
+test('throws exception on invalid integer', function () {
+    $this->expectException(InvalidArgumentException::class);
+
+    new Boolean(2);
+});
+
 test('boolean can accept integer as a string', function () {
     $valueObject = new Boolean('0');
     $this->assertFalse($valueObject->value());
@@ -105,10 +111,10 @@
     Boolean::macro('getNegativeValues', fn () => $this->falseValues);
     $valueObject = new Boolean(1);
     $this->assertSame([
-        '1', 'true', 1, 'on', 'yes',
+        '1', 'true', 'on', 'yes',
     ], $valueObject->getPositiveValues());
     $this->assertSame([
-        '0', 'false', 0, 'off', 'no',
+        '0', 'false', 'off', 'no',
     ], $valueObject->getNegativeValues());
 });