Merge pull request #175 from kasturinarra/fix_issue_174

ISSUE-174: Annotate topolvm-provisioner sc as default

Author: ggiguash

.github/workflows/cncf-conformance.yaml

@@ -81,14 +81,6 @@ jobs:
             sudo podman exec "${node}" systemctl disable firewalld || true
           done
 
-          # Set default storage class for CNCF conformance tests
-          echo "Setting default storage class annotation..."
-          make env CMD="kubectl annotate storageclass topolvm-provisioner storageclass.kubernetes.io/is-default-class=true"
-
-          # Verify the annotation was applied
-          echo "Verifying default storage class:"
-          make env CMD="kubectl get storageclass topolvm-provisioner -o yaml | grep -A2 annotations"
-
       - name: Run CNCF conformance tests with Sonobuoy
         id: run-sonobuoy
         shell: bash

src/topolvm/assets/02-topolvm.yaml

@@ -83,6 +83,7 @@ kind: StorageClass
 metadata:
   name: topolvm-provisioner
   annotations:
+    storageclass.kubernetes.io/is-default-class: "true"
   labels:
     helm.sh/chart: topolvm-15.5.2
     app.kubernetes.io/name: topolvm

src/topolvm/generate_manifests.sh

@@ -42,7 +42,12 @@ EOF
   # Patch replicas to 1
   # shellcheck disable=SC2016
   yq 'select(.kind == "Deployment").spec.replicas = 1' -i "${ASSETS_DIR}/02-topolvm.yaml"
-  
+
+  # Annotate topolvm-provisioner StorageClass as default
+  yq 'with(select(.kind == "StorageClass" and .metadata.name == "topolvm-provisioner");
+  .metadata.annotations."storageclass.kubernetes.io/is-default-class" = "true"
+  )' -i "${ASSETS_DIR}/02-topolvm.yaml"
+
   # Patch topolvm-controller manifest with longer startup delay to allow dns to start
   yq 'with(select(.kind == "Deployment" and .metadata.name == "topolvm-controller").spec.template.spec.containers[] | select(.name == "topolvm-controller");
   .livenessProbe.failureThreshold = 3 |