Skip to content

Commit 4788581

Browse files
committed
Addressing CR feedback
1 parent 82b6aca commit 4788581

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

src/compiler/emitter.ts

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ module ts {
9292

9393
let currentSourceFile: SourceFile;
9494

95-
let generatedNameSet: Map<string>;
96-
let nodeToGeneratedName: string[];
95+
let generatedNameSet: Map<string> = {};
96+
let nodeToGeneratedName: string[] = [];
9797
let blockScopedVariableToGeneratedName: string[];
9898
let computedPropertyNamesToGeneratedNames: string[];
9999

@@ -170,7 +170,7 @@ module ts {
170170
function isUniqueName(name: string): boolean {
171171
return !resolver.hasGlobalName(name) &&
172172
!hasProperty(currentSourceFile.identifiers, name) &&
173-
(!generatedNameSet || !hasProperty(generatedNameSet, name))
173+
!hasProperty(generatedNameSet, name);
174174
}
175175

176176
// Return the next available name in the pattern _a ... _z, _0, _1, ...
@@ -186,11 +186,13 @@ module ts {
186186
}
187187
while (true) {
188188
let count = tempFlags & TempFlags.CountMask;
189-
let ch = CharacterCodes.a + count;
190-
let name = count < 26 ? "_" + String.fromCharCode(ch) : "_" + (count - 26);
191189
tempFlags++;
192-
if (ch !== CharacterCodes.i && ch !== CharacterCodes.n && isUniqueName(name)) {
193-
return name;
190+
// Skip over 'i' and 'n'
191+
if (count !== 8 && count !== 13) {
192+
let name = count < 26 ? "_" + String.fromCharCode(CharacterCodes.a + count) : "_" + (count - 26);
193+
if (isUniqueName(name)) {
194+
return name;
195+
}
194196
}
195197
}
196198
}
@@ -208,14 +210,14 @@ module ts {
208210
while (true) {
209211
let generatedName = baseName + i;
210212
if (isUniqueName(generatedName)) {
211-
return (generatedNameSet || (generatedNameSet = {}))[generatedName] = generatedName;
213+
return generatedNameSet[generatedName] = generatedName;
212214
}
213215
i++;
214216
}
215217
}
216218

217219
function assignGeneratedName(node: Node, name: string) {
218-
(nodeToGeneratedName || (nodeToGeneratedName = []))[getNodeId(node)] = unescapeIdentifier(name);
220+
nodeToGeneratedName[getNodeId(node)] = unescapeIdentifier(name);
219221
}
220222

221223
function generateNameForFunctionOrClassDeclaration(node: Declaration) {
@@ -284,10 +286,10 @@ module ts {
284286

285287
function getGeneratedNameForNode(node: Node) {
286288
let nodeId = getNodeId(node);
287-
if (!nodeToGeneratedName || !nodeToGeneratedName[nodeId]) {
289+
if (!nodeToGeneratedName[nodeId]) {
288290
generateNameForNode(node);
289291
}
290-
return nodeToGeneratedName ? nodeToGeneratedName[nodeId] : undefined;
292+
return nodeToGeneratedName[nodeId];
291293
}
292294

293295
function initializeEmitterWithSourceMaps() {

0 commit comments

Comments
 (0)