addressed PR feedback

vladima · vladima · commit 7f8ef3881ba3 · 2015-03-16T13:36:34.000-07:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -3917,7 +3917,8 @@ module ts {
                     renameNonTopLevelLetAndConst(name);
                     if (name.parent && (name.parent.kind === SyntaxKind.VariableDeclaration || name.parent.kind === SyntaxKind.BindingElement)) {
                         emitModuleMemberName(<Declaration>name.parent);
-                    } else {
+                    }
+                    else {
                         emit(name);
                     }
                     write(" = ");
@@ -5373,7 +5374,7 @@ module ts {
                     emitLeadingComments(node);
                 }
 
-                emitJavaScriptWorker(node, (allowGeneratedIdentifiers === undefined) || allowGeneratedIdentifiers);
+                emitJavaScriptWorker(node, allowGeneratedIdentifiers);
 
                 if (emitComments) {
                     emitTrailingComments(node);
@@ -5389,7 +5390,7 @@ module ts {
                     return emitPinnedOrTripleSlashComments(node);
                 }
 
-                emitJavaScriptWorker(node, (allowGeneratedIdentifiers === undefined) || allowGeneratedIdentifiers);
+                emitJavaScriptWorker(node, allowGeneratedIdentifiers);
             }
 
             function shouldEmitLeadingAndTrailingComments(node: Node) {
@@ -5419,7 +5420,7 @@ module ts {
                 return true;
             }
 
-            function emitJavaScriptWorker(node: Node, allowGeneratedIdentifiers: boolean) {
+            function emitJavaScriptWorker(node: Node, allowGeneratedIdentifiers: boolean = true) {
                 // Check if the node can be emitted regardless of the ScriptTarget
                 switch (node.kind) {
                     case SyntaxKind.Identifier:

Original file line number	Diff line number	Diff line change
`@@ -3917,7 +3917,8 @@ module ts {`
`3917`	`3917`	`renameNonTopLevelLetAndConst(name);`
`3918`	`3918`	`if (name.parent && (name.parent.kind === SyntaxKind.VariableDeclaration \|\| name.parent.kind === SyntaxKind.BindingElement)) {`
`3919`	`3919`	`emitModuleMemberName(<Declaration>name.parent);`
`3920`		`- } else {`
	`3920`	`+ }`
	`3921`	`+ else {`
`3921`	`3922`	`emit(name);`
`3922`	`3923`	`}`
`3923`	`3924`	`write(" = ");`
`@@ -5373,7 +5374,7 @@ module ts {`
`5373`	`5374`	`emitLeadingComments(node);`
`5374`	`5375`	`}`
`5375`	`5376`
`5376`		`- emitJavaScriptWorker(node, (allowGeneratedIdentifiers === undefined) \|\| allowGeneratedIdentifiers);`
	`5377`	`+ emitJavaScriptWorker(node, allowGeneratedIdentifiers);`
`5377`	`5378`
`5378`	`5379`	`if (emitComments) {`
`5379`	`5380`	`emitTrailingComments(node);`
`@@ -5389,7 +5390,7 @@ module ts {`
`5389`	`5390`	`return emitPinnedOrTripleSlashComments(node);`
`5390`	`5391`	`}`
`5391`	`5392`
`5392`		`- emitJavaScriptWorker(node, (allowGeneratedIdentifiers === undefined) \|\| allowGeneratedIdentifiers);`
	`5393`	`+ emitJavaScriptWorker(node, allowGeneratedIdentifiers);`
`5393`	`5394`	`}`
`5394`	`5395`
`5395`	`5396`	`function shouldEmitLeadingAndTrailingComments(node: Node) {`
`@@ -5419,7 +5420,7 @@ module ts {`
`5419`	`5420`	`return true;`
`5420`	`5421`	`}`
`5421`	`5422`
`5422`		`- function emitJavaScriptWorker(node: Node, allowGeneratedIdentifiers: boolean) {`
	`5423`	`+ function emitJavaScriptWorker(node: Node, allowGeneratedIdentifiers: boolean = true) {`
`5423`	`5424`	`// Check if the node can be emitted regardless of the ScriptTarget`
`5424`	`5425`	`switch (node.kind) {`
`5425`	`5426`	`case SyntaxKind.Identifier:`