Skip to content

Commit 5c9f393

Browse files
committed
Logs info/default log messages to eclipse logs only if tracing is
enabled. LSP4E by default logs info/default messages to Eclipse logs. But we want to log info only if tracing is enabled. see https://github.com/microsoft/copilot-eclipse-feedback/issues/185
1 parent d269a2b commit 5c9f393

1 file changed

Lines changed: 33 additions & 0 deletions

File tree

com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageClient.java

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,16 @@
1313
import org.eclipse.core.resources.IFile;
1414
import org.eclipse.core.runtime.IProgressMonitor;
1515
import org.eclipse.core.runtime.IStatus;
16+
import org.eclipse.core.runtime.Platform;
1617
import org.eclipse.core.runtime.Status;
1718
import org.eclipse.core.runtime.jobs.Job;
1819
import org.eclipse.e4.core.contexts.EclipseContextFactory;
1920
import org.eclipse.e4.core.services.events.IEventBroker;
2021
import org.eclipse.lsp4e.LanguageClientImpl;
2122
import org.eclipse.lsp4j.ConfigurationItem;
2223
import org.eclipse.lsp4j.ConfigurationParams;
24+
import org.eclipse.lsp4j.MessageParams;
25+
import org.eclipse.lsp4j.MessageType;
2326
import org.eclipse.lsp4j.ProgressParams;
2427
import org.eclipse.lsp4j.ShowDocumentParams;
2528
import org.eclipse.lsp4j.ShowDocumentResult;
@@ -402,4 +405,34 @@ protected IStatus run(IProgressMonitor monitor) {
402405
return super.showDocument(params);
403406
}
404407
}
408+
409+
@Override
410+
public void logMessage(MessageParams message) {
411+
if (message == null) {
412+
return;
413+
}
414+
415+
MessageType type = message.getType();
416+
if (type == null) {
417+
return;
418+
}
419+
420+
switch (type) {
421+
case Error:
422+
case Warning:
423+
super.logMessage(message);
424+
break;
425+
case Info:
426+
case Log:
427+
default:
428+
if (isLsp4eLogTraceEnabled()) {
429+
super.logMessage(message);
430+
}
431+
break;
432+
}
433+
}
434+
435+
private boolean isLsp4eLogTraceEnabled() {
436+
return Platform.getDebugBoolean("org.eclipse.lsp4e/trace");
437+
}
405438
}

0 commit comments

Comments
 (0)