Address on-demand sandbox review feedback

Remove the checked-in on-demand sandbox proto source and extend proto generation to fetch it from durabletask-protobuf using the recorded source hash. Simplify the preview changelog entry and use Durable Task Scheduler in new public prose instead of DTS shorthand.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: YunchuWang

Makefile

@@ -9,8 +9,12 @@ install:
 
 gen-proto:
 	curl -o durabletask/internal/orchestrator_service.proto https://raw.githubusercontent.com/microsoft/durabletask-protobuf/refs/heads/main/protos/orchestrator_service.proto
-	curl -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/microsoft/durabletask-protobuf/commits?path=protos/orchestrator_service.proto&sha=main&per_page=1" | jq -r '.[0].sha' >> durabletask/internal/PROTO_SOURCE_COMMIT_HASH
+	curl -H "Accept: application/vnd.github.v3+json" "https://api.github.com/repos/microsoft/durabletask-protobuf/commits?path=protos/orchestrator_service.proto&sha=main&per_page=1" | jq -r '.[0].sha' > durabletask/internal/PROTO_SOURCE_COMMIT_HASH
 	python3 -m grpc_tools.protoc --proto_path=.  --python_out=. --pyi_out=. --grpc_python_out=. ./durabletask/internal/orchestrator_service.proto
 	rm durabletask/internal/*.proto
+	ON_DEMAND_SANDBOX_PROTO_SOURCE_COMMIT_HASH=$$(cat durabletask-azuremanaged/durabletask/azuremanaged/internal/ON_DEMAND_SANDBOX_PROTO_SOURCE_COMMIT_HASH); \
+	curl -o durabletask-azuremanaged/durabletask/azuremanaged/internal/on_demand_sandbox_activities_service.proto https://raw.githubusercontent.com/microsoft/durabletask-protobuf/$${ON_DEMAND_SANDBOX_PROTO_SOURCE_COMMIT_HASH}/protos/serverless_activities_service.proto
+	python3 -m grpc_tools.protoc --proto_path=. --python_out=. --pyi_out=. --grpc_python_out=. ./durabletask-azuremanaged/durabletask/azuremanaged/internal/on_demand_sandbox_activities_service.proto
+	rm durabletask-azuremanaged/durabletask/azuremanaged/internal/*.proto
 
 .PHONY: init test gen-proto install

durabletask-azuremanaged/CHANGELOG.md

@@ -8,21 +8,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ## Unreleased
 
 - Added preview `durabletask.azuremanaged.preview.on_demand_sandbox` APIs for
-  declaring DTS on-demand sandbox activities and running a sandbox activity worker.
-- Added profile-based DTS on-demand sandbox declarations with
-  `@on_demand_sandbox_worker_profile`, `OnDemandSandboxWorkerProfile.configure()`,
-  `OnDemandSandboxWorkerProfileOptions.add_activity(...)`, and
-  `OnDemandSandboxActivitiesClient.enable_on_demand_sandbox_activities()`.
-- Changed on-demand sandbox worker profile declarations so the decorator names the
-  profile and the profile class configures image, resources, concurrency, and
-  customer environment variables explicitly.
-- Changed on-demand sandbox activity worker configuration to require explicit SDK
-  parameters instead of reading DTS environment variables inside the SDK.
-- Removed the on-demand sandbox worker wakeup HTTP listener because ADC sandbox
-  workers use outbound DTS registration and do not require an inbound probe
-  endpoint.
-- Changed on-demand sandbox worker registration to rely on gRPC status instead of an
-  accepted response flag.
+  declaring Durable Task Scheduler on-demand sandbox activities, registering
+  worker profiles, and running sandbox activity workers.
 
 ## v1.5.0
 

durabletask-azuremanaged/durabletask/azuremanaged/internal/on_demand_sandbox_activities_service.proto

@@ -2,4 +2,3 @@
 # Licensed under the MIT License.
 
 """Preview Azure Managed Durable Task Scheduler APIs."""
-

durabletask-azuremanaged/durabletask/azuremanaged/preview/__init__.py

@@ -4,8 +4,8 @@
 """On-demand sandbox preview APIs for Azure Managed Durable Task Scheduler.
 
 This extension provides preview APIs for declaring on-demand sandbox activity
-worker images and running a Python activity worker inside a DTS-launched
-sandbox.
+worker images and running a Python activity worker inside a Durable Task
+Scheduler-launched sandbox.
 
 Usage::
 
@@ -28,4 +28,3 @@
     "OnDemandSandboxActivitiesClient",
     "on_demand_sandbox_worker_profile",
 ]
-

durabletask-azuremanaged/durabletask/azuremanaged/preview/on_demand_sandbox/__init__.py

@@ -161,7 +161,7 @@ def build_on_demand_sandbox_activity_declaration(
 
     resolved_scheduler_managed_identity_client_id = _normalize_required(
         scheduler_managed_identity_client_id,
-        "On-demand sandbox activity declaration requires the managed identity client ID workers use to connect to the DTS scheduler.")
+        "On-demand sandbox activity declaration requires the managed identity client ID workers use to connect to Durable Task Scheduler.")
     resolved_image_pull_managed_identity_client_id = _normalize_required(
         image_pull_managed_identity_client_id,
         "On-demand sandbox activity declaration requires the managed identity client ID ADC uses to pull the worker image.")
@@ -265,7 +265,7 @@ def build_on_demand_sandbox_worker_heartbeat(active_activities_count: int) -> pb
 
 
 class OnDemandSandboxActivitiesClient:
-    """Client for DTS on-demand sandbox activity management operations."""
+    """Client for Durable Task Scheduler on-demand sandbox activity management operations."""
 
     def __init__(
             self, *,
@@ -298,7 +298,7 @@ def close(self) -> None:
             self._channel.close()
 
     def enable_on_demand_sandbox_activities(self) -> None:
-        """Declare all configured on-demand sandbox worker profiles with DTS."""
+        """Declare all configured on-demand sandbox worker profiles with Durable Task Scheduler."""
         declarations = build_profile_on_demand_sandbox_activity_declarations()
         if not declarations:
             raise ValueError("No configured on-demand sandbox activities were found.")

durabletask-azuremanaged/durabletask/azuremanaged/preview/on_demand_sandbox/client.py

@@ -27,10 +27,10 @@
 
 
 class OnDemandSandboxWorker(DurableTaskSchedulerWorker):
-    """DTS worker mode for activity containers started by on-demand sandbox activities.
+    """Durable Task Scheduler worker mode for activity containers started by on-demand sandbox activities.
 
-    This worker registers a live worker session with DTS and restricts dispatch
-    to the activities registered on this worker.
+    This worker registers a live worker session with Durable Task Scheduler and
+    restricts dispatch to the activities registered on this worker.
     """
 
     def __init__(self):

durabletask-azuremanaged/durabletask/azuremanaged/preview/on_demand_sandbox/worker.py

@@ -1,11 +1,11 @@
-# DTS on-demand sandbox activities sample
+# Durable Task Scheduler on-demand sandbox activities sample
 
-This sample mirrors the .NET on-demand sandbox sample with two customer-owned pieces:
+This sample mirrors the .NET on-demand sandbox sample with three customer-owned pieces:
 
 1. A **declarer app** (`main_app.py`) that declares which activity should run
    in an on-demand sandbox, starts the orchestration, and waits for the result.
 2. A **remote worker image** (`remote_worker.py` plus `Containerfile`) that
-   DTS starts in a sandbox to execute the declared activity.
+   Durable Task Scheduler starts in a sandbox to execute the declared activity.
 3. A tiny shared module (`activity_names.py`) that keeps the declarer and remote
    worker on the same activity name constants.
 
@@ -36,12 +36,12 @@ memory, max concurrency, customer environment variables, and on-demand sandbox a
 names with `options.add_activity(...)`. The declarer and remote worker both use
 `activity_names.py` so they stay in sync.
 
-The remote worker code cannot pass DTS runtime settings to the SDK. In a
+The remote worker code cannot pass Durable Task Scheduler runtime settings to the SDK. In a
 sandbox, `OnDemandSandboxWorker()` reads `DTS_ENDPOINT`,
 `DTS_TASK_HUB`, `DTS_WORKER_PROFILE_ID`, `DTS_ON_DEMAND_SANDBOX_MAX_ACTIVITIES`,
 `DTS_SUBSTRATE`, and `DTS_SANDBOX_ID` from environment variables injected by
-DTS. The worker reports its registered activity names when it connects, and
-DTS validates they match the declaration before advertising worker capacity.
+Durable Task Scheduler. The worker reports its registered activity names when it connects, and
+Durable Task Scheduler validates they match the declaration before advertising worker capacity.
 
 ## Build the remote worker image
 
@@ -55,7 +55,7 @@ docker build `
 docker push <public container image reference>
 ```
 
-Private preview requires the image to be publicly pullable by ADC/DTS.
+Private preview requires the image to be publicly pullable by the sandbox platform.
 
 ## Run the declarer app
 

examples/on_demand_sandbox/README.md

@@ -1,4 +1,4 @@
-"""Declarer app for the DTS on-demand sandbox activities sample."""
+"""Declarer app for the Durable Task Scheduler on-demand sandbox activities sample."""
 
 import os
 

examples/on_demand_sandbox/main_app.py

@@ -1,4 +1,4 @@
-"""Remote worker image entrypoint for the DTS on-demand sandbox activities sample."""
+"""Remote worker image entrypoint for the Durable Task Scheduler on-demand sandbox activities sample."""
 
 import os
 import time