Pyright fixes

Author: andystaples

azure-functions-durable/azure/durable_functions/decorators/durable_app.py

@@ -65,7 +65,8 @@ def _register_builtin_http_functions(self) -> None:
             activity=BUILTIN_HTTP_ACTIVITY_NAME)(builtin_http_activity)
         self.orchestration_trigger(
             context_name="context",
-            orchestration=BUILTIN_HTTP_POLL_ORCHESTRATOR_NAME)(builtin_http_poll_orchestrator)
+            orchestration=BUILTIN_HTTP_POLL_ORCHESTRATOR_NAME)(
+                builtin_http_poll_orchestrator)  # pyright: ignore[reportArgumentType]
 
     def configure_scheduled_tasks(self) -> None:
         """Opt in to durabletask scheduled tasks by registering their built-ins.
@@ -138,14 +139,19 @@ def configure_history_export(self) -> None:
             context_name="context", entity_name=EXPORT_ENTITY_NAME)(ExportJobEntity)
         self.orchestration_trigger(context_name="context")(export_job_orchestrator)
 
-        def _list_terminal_instances(input: dict) -> dict:
+        def _list_terminal_instances(input: dict[str, Any]) -> dict[str, Any]:
             return list_terminal_instances(None, input)  # type: ignore[arg-type]
 
-        def _export_instance_history(input: dict) -> dict:
+        def _export_instance_history(input: dict[str, Any]) -> dict[str, Any]:
             return export_instance_history(None, input)  # type: ignore[arg-type]
 
         _list_terminal_instances.__name__ = LIST_TERMINAL_INSTANCES_ACTIVITY
         _export_instance_history.__name__ = EXPORT_INSTANCE_HISTORY_ACTIVITY
+        # The worker reads the runtime ``__annotations__`` during indexing and
+        # rejects parameterized generics, so reset them to the bare ``dict`` it
+        # accepts (the signatures above stay typed for static analysis).
+        _list_terminal_instances.__annotations__ = {"input": dict, "return": dict}
+        _export_instance_history.__annotations__ = {"input": dict, "return": dict}
         self.activity_trigger(
             input_name="input",
             activity=LIST_TERMINAL_INSTANCES_ACTIVITY)(_list_terminal_instances)

azure-functions-durable/azure/durable_functions/http/builtin.py

@@ -59,7 +59,7 @@ def _acquire_bearer_token(resource: str) -> str:
     return credential.get_token(scope).token
 
 
-def builtin_http_activity(input: dict) -> dict:
+def builtin_http_activity(input: dict[str, Any]) -> dict[str, Any]:
     """Execute a single HTTP request and return the response payload.
 
     ``input`` is the JSON form of a
@@ -68,14 +68,14 @@ def builtin_http_activity(input: dict) -> dict:
     return value is the JSON form of a
     :class:`~azure.durable_functions.http.models.DurableHttpResponse`.
 
-    The parameter and return are annotated with the plain ``dict`` type on
-    purpose. The Azure Functions Python worker inspects trigger annotations
-    during indexing and requires them to be a real ``type`` (it rejects
+    The parameter and return are declared as ``dict[str, Any]`` for static type
+    checking, but the *runtime* annotations are reset to the bare ``dict`` type
+    just below the function. The Azure Functions Python worker inspects trigger
+    annotations during indexing and requires a real ``type`` -- it rejects
     parameterized generics such as ``dict[str, Any]`` with
     ``FunctionLoadError: ... invalid non-type annotation`` and, for a
     ``typing.Union`` origin like ``Optional[...]``, raises
-    ``TypeError: issubclass() arg 1 must be a class``). A bare ``dict`` keeps
-    worker indexing happy while the body still defends against ``None`` below.
+    ``TypeError: issubclass() arg 1 must be a class``.
     """
     request = input or {}
     method = str(request.get("method", "GET")).upper()
@@ -113,6 +113,13 @@ def builtin_http_activity(input: dict) -> dict:
         status_code=status, headers=resp_headers, content=body).to_json()
 
 
+# The Azure Functions worker reads a trigger function's runtime ``__annotations__``
+# during indexing and rejects parameterized generics (it requires a bare
+# ``dict``). The signature above is typed ``dict[str, Any]`` for static analysis;
+# reset the runtime annotations to the bare ``dict`` the worker accepts.
+builtin_http_activity.__annotations__ = {"input": dict, "return": dict}
+
+
 def _get_header(headers: dict[str, str], name: str) -> Optional[str]:
     """Case-insensitively look up ``name`` in ``headers``."""
     lowered = name.lower()
@@ -135,11 +142,9 @@ def _retry_after_seconds(headers: dict[str, str]) -> int:
     if raw.isdigit():
         return max(int(raw), 0)
     try:
-        retry_at = parsedate_to_datetime(raw)
+        parsedate_to_datetime(raw)
     except (TypeError, ValueError):
         return _DEFAULT_POLL_INTERVAL_SECONDS
-    if retry_at is None:
-        return _DEFAULT_POLL_INTERVAL_SECONDS
     return _DEFAULT_POLL_INTERVAL_SECONDS
 
 
@@ -156,7 +161,7 @@ def builtin_http_poll_orchestrator(context: Any) -> Generator[Any, Any, dict[str
         BUILTIN_HTTP_ACTIVITY_NAME, request)
 
     while response.get("status_code") == 202:
-        headers = response.get("headers") or {}
+        headers: dict[str, str] = response.get("headers") or {}
         location = _get_header(headers, "Location")
         if not location:
             # Cannot poll without a Location; return the 202 as-is.

azure-functions-durable/azure/durable_functions/internal/compat/durable_orchestration_status.py

@@ -114,7 +114,9 @@ def output(self) -> Any:
     @property
     def runtime_status(self) -> Optional[OrchestrationRuntimeStatus]:
         """Get the runtime status as a v1 ``OrchestrationRuntimeStatus``."""
-        if self._state is None or self._state.runtime_status is None:
+        # ``OrchestrationState.runtime_status`` is typed ``OrchestrationStatus``
+        # but is built via ``cast`` from a value that can be ``None`` at runtime
+        if self._state is None or self._state.runtime_status is None:  # pyright: ignore[reportUnnecessaryComparison]
             return None
         return from_durabletask_status(self._state.runtime_status)
 

azure-functions-durable/azure/durable_functions/internal/history_export_compat.py

@@ -28,7 +28,7 @@
 from durabletask.internal.helpers import ensure_aware
 
 from durabletask.extensions.history_export._internal import dt_from_iso
-from durabletask.extensions.history_export.activities import _require_context
+from durabletask.extensions.history_export.activities import _require_context  # pyright: ignore[reportPrivateUsage]
 
 # The activity registers under the same name the export orchestrator calls, so
 # it transparently replaces the core activity.