Django 5.0 support (#327)

* basic 5.0 support

* use django main branch

* use alpha 5.0 branch

* preliminary fix for nulls_distinct

* add _unique_supported function

* Fix schema db default test

* Skip constraint tests

* Support db_default field

* Remove operations test fixes

* Preliminary fix

* Check version before accessing db_default

* Skip add field database default test

* Update returned values from insert

* Change can_return_rows_from_bulk_insert default to True

* Revert format sql changes

* Prevent formatting empty params query

* unskip add_field_database_default

* fix add_field_both_defaults test

* Update nullable default field behavior

* update odbc 17 windows ci

* reduce tox tests for testing purposes

* bump tox version to 5.0

* add field_defaults

* Fix default constraints test

* unskip tox tests

---------

Co-authored-by: Daniel Au (SIMBA TECHNOLOGIES INC) <v-audaniel@microsoft.com>
Co-authored-by: dauinsight <145612907+dauinsight@users.noreply.github.com>

Author: mShan0

azure-pipelines.yml

@@ -24,6 +24,16 @@ jobs:
 
     strategy:
       matrix:
+        Python3.12 - Django 5.0:
+          python.version: '3.12'
+          tox.env: 'py312-django50'
+        Python3.11 - Django 5.0:
+          python.version: '3.11'
+          tox.env: 'py311-django50'
+        Python3.10 - Django 5.0:
+          python.version: '3.10'
+          tox.env: 'py310-django50'
+
         Python3.11 - Django 4.2:
           python.version: '3.11'
           tox.env: 'py311-django42'
@@ -92,7 +102,7 @@ jobs:
 
           (Get-Content $pwd/testapp/settings.py).replace('localhost', $IP) | Set-Content $pwd/testapp/settings.py
 
-          Invoke-WebRequest https://download.microsoft.com/download/E/6/B/E6BFDC7A-5BCD-4C51-9912-635646DA801E/en-US/17.5.2.1/x64/msodbcsql.msi -OutFile msodbcsql.msi
+          Invoke-WebRequest https://download.microsoft.com/download/6/f/f/6ffefc73-39ab-4cc0-bb7c-4093d64c2669/en-US/17.10.5.1/x64/msodbcsql.msi -OutFile msodbcsql.msi
           msiexec /quiet /passive /qn /i msodbcsql.msi IACCEPTMSODBCSQLLICENSETERMS=YES
           Get-OdbcDriver
         displayName: Install ODBC
@@ -131,6 +141,16 @@ jobs:
 
     strategy:
       matrix:
+        Python3.12 - Django 5.0:
+          python.version: '3.12'
+          tox.env: 'py312-django50'
+        Python3.11 - Django 5.0:
+          python.version: '3.11'
+          tox.env: 'py311-django50'
+        Python3.10 - Django 5.0:
+          python.version: '3.10'
+          tox.env: 'py310-django50'
+
         Python3.11 - Django 4.2:
           python.version: '3.11'
           tox.env: 'py311-django42'

mssql/base.py

@@ -581,7 +581,7 @@ def format_sql(self, sql, params):
             sql = smart_str(sql, self.driver_charset)
 
         # pyodbc uses '?' instead of '%s' as parameter placeholder.
-        if params is not None:
+        if params is not None and params != []:
             sql = sql % tuple('?' * len(params))
 
         return sql

mssql/features.py

@@ -13,7 +13,7 @@ class DatabaseFeatures(BaseDatabaseFeatures):
     can_introspect_small_integer_field = True
     can_return_columns_from_insert = True
     can_return_id_from_insert = True
-    can_return_rows_from_bulk_insert = False
+    can_return_rows_from_bulk_insert = True
     can_rollback_ddl = True
     can_use_chunked_reads = False
     for_update_after_from = True
@@ -57,6 +57,9 @@ class DatabaseFeatures(BaseDatabaseFeatures):
     supports_partially_nullable_unique_constraints = True
     supports_partial_indexes = True
     supports_functions_in_partial_indexes = True
+    supports_default_keyword_in_insert = True
+    supports_expression_defaults = True
+    supports_default_keyword_in_bulk_insert = True
 
     @cached_property
     def has_zoneinfo_database(self):

mssql/introspection.py

@@ -164,6 +164,17 @@ def get_table_description(self, cursor, table_name, identity_check=True):
                     column[1] = SQL_AUTOFIELD
             if column[1] == Database.SQL_WVARCHAR and column[3] < 4000:
                 column[1] = Database.SQL_WCHAR
+            # Remove surrounding parentheses for default values
+            if column[7]:
+                default_value = column[7]
+                start = 0
+                end = -1
+                for _ in range(2):
+                    if default_value[start] == '(' and default_value[end] == ')':
+                        start += 1
+                        end -= 1
+                column[7] = default_value[start:end + 1]
+
             if VERSION >= (4, 2):
                 items.append(FieldInfo(*column))
             else:
@@ -304,6 +315,7 @@ def get_constraints(self, cursor, table_name):
                     # Potentially misleading: primary key and unique constraints still have indexes attached to them.
                     # Should probably be updated with the additional info from the sys.indexes table we fetch later on.
                     "index": False,
+                    "default": False,
                 }
             # Record the details
             constraints[constraint]['columns'].append(column)
@@ -331,6 +343,32 @@ def get_constraints(self, cursor, table_name):
                     "foreign_key": None,
                     "check": True,
                     "index": False,
+                    "default": False,
+                }
+            # Record the details
+            constraints[constraint]['columns'].append(column)
+        # Now get DEFAULT constraint columns
+        cursor.execute("""
+            SELECT
+                [name],
+                COL_NAME([parent_object_id], [parent_column_id])
+            FROM
+                [sys].[default_constraints]
+            WHERE
+                OBJECT_NAME([parent_object_id]) = %s
+        """, [table_name])
+        for constraint, column in cursor.fetchall():
+            # If we're the first column, make the record
+            if constraint not in constraints:
+                constraints[constraint] = {
+                    "columns": [],
+                    "primary_key": False,
+                    "unique": False,
+                    "unique_constraint": False,
+                    "foreign_key": None,
+                    "check": False,
+                    "index": False,
+                    "default": True,
                 }
             # Record the details
             constraints[constraint]['columns'].append(column)
@@ -374,6 +412,7 @@ def get_constraints(self, cursor, table_name):
                     "unique_constraint": unique_constraint,
                     "foreign_key": None,
                     "check": False,
+                    "default": False,
                     "index": True,
                     "orders": [],
                     "type": Index.suffix if type_ in (1, 2) else desc.lower(),