working

Author: gargsaumya

main.py

@@ -5,17 +5,21 @@
 
 setup_logging('stdout')
 
-conn_str = os.getenv("DB_CONNECTION_STRING")
+# conn_str = os.getenv("DB_CONNECTION_STRING")
+conn_str = "Server=Saumya;DATABASE=master;UID=sa;PWD=HappyPass1234;Trust_Connection=yes;TrustServerCertificate=yes;"
+
 conn = connect(conn_str)
 
 # conn.autocommit = True
 
 cursor = conn.cursor()
-cursor.execute("SELECT database_id, name from sys.databases;")
-rows = cursor.fetchall()
-
-for row in rows:
-    print(f"Database ID: {row[0]}, Name: {row[1]}")
-
-cursor.close()
-conn.close()
+cursor.execute("DROP TABLE IF EXISTS test_decimal")
+cursor.execute("CREATE TABLE test_decimal (val DECIMAL(38, 10))")
+cursor.execute("INSERT INTO test_decimal (val) VALUES (?)", (decimal.Decimal('1234567890.1234567890'),))
+cursor.commit()
+print("Inserted value")
+cursor.execute("SELECT val FROM test_decimal")
+row = cursor.fetchone()
+print(f"Fetched value: {row[0]}")
+print(f"Type of fetched value: {type(row[0])}")
+assert row[0] == decimal.Decimal('1234567890.1234567890')

mssql_python/cursor.py

@@ -195,7 +195,8 @@ def _get_numeric_data(self, param):
             the numeric data.
         """
         decimal_as_tuple = param.as_tuple()
-        num_digits = len(decimal_as_tuple.digits)
+        digits_tuple = decimal_as_tuple.digits
+        num_digits = len(digits_tuple)
         exponent = decimal_as_tuple.exponent
 
         # Calculate the SQL precision & scale
@@ -216,11 +217,11 @@ def _get_numeric_data(self, param):
             scale = exponent * -1
 
         # TODO: Revisit this check, do we want this restriction?
-        if precision > 15:
+        if precision > 38:
             raise ValueError(
                 "Precision of the numeric value is too high - "
                 + str(param)
-                + ". Should be less than or equal to 15"
+                + ". Should be less than or equal to 38"
             )
         Numeric_Data = ddbc_bindings.NumericData
         numeric_data = Numeric_Data()
@@ -229,12 +230,32 @@ def _get_numeric_data(self, param):
         numeric_data.sign = 1 if decimal_as_tuple.sign == 0 else 0
         # strip decimal point from param & convert the significant digits to integer
         # Ex: 12.34 ---> 1234
-        val = str(param)
-        if "." in val or "-" in val:
-            val = val.replace(".", "")
-            val = val.replace("-", "")
-        val = int(val)
-        numeric_data.val = val
+        int_str = ''.join(str(d) for d in digits_tuple)
+
+        # Apply exponent to get the unscaled integer string
+        if exponent > 0:
+            int_str = int_str + ('0' * exponent)
+        elif exponent < 0:
+            # if exponent negative and abs(exponent) > num_digits we padded precision above
+            # for the integer representation we pad leading zeros
+            if -exponent > num_digits:
+                int_str = ('0' * (-exponent - num_digits)) + int_str
+
+        # Edge: if int_str becomes empty (Decimal('0')), make "0"
+        if int_str == '':
+            int_str = '0'
+
+        # Convert decimal base-10 string -> python int, then to 16 little-endian bytes
+        big_int = int(int_str)  # Python big int is arbitrary precision
+        byte_array = bytearray(16)  # SQL_MAX_NUMERIC_LEN
+        for i in range(16):
+            byte_array[i] = big_int & 0xFF
+            big_int >>= 8
+            if big_int == 0:
+                break
+
+        # numeric_data.val should be bytes (pybindable). Ensure a bytes object of length 16.
+        numeric_data.val = bytes(byte_array)
         return numeric_data
 
     def _map_sql_type(self, param, parameters_list, i, min_val=None, max_val=None):

mssql_python/pybind/ddbc_bindings.cpp

@@ -21,6 +21,7 @@
 #define SQL_SS_TIMESTAMPOFFSET (-155)
 #define SQL_C_SS_TIMESTAMPOFFSET (0x4001)
 #define MAX_DIGITS_IN_NUMERIC 64
+#define SQL_MAX_NUMERIC_LEN 16
 
 #define STRINGIFY_FOR_CASE(x) \
     case x:                   \
@@ -56,12 +57,16 @@ struct NumericData {
     SQLCHAR precision;
     SQLSCHAR scale;
     SQLCHAR sign;  // 1=pos, 0=neg
-    std::uint64_t val; // 123.45 -> 12345
+    std::string val; // 123.45 -> 12345
 
-    NumericData() : precision(0), scale(0), sign(0), val(0) {}
+    NumericData() : precision(0), scale(0), sign(0), val(SQL_MAX_NUMERIC_LEN, '\0') {}
 
-    NumericData(SQLCHAR precision, SQLSCHAR scale, SQLCHAR sign, std::uint64_t value)
-        : precision(precision), scale(scale), sign(sign), val(value) {}
+    NumericData(SQLCHAR precision, SQLSCHAR scale, SQLCHAR sign, const std::string& valueBytes)
+        : precision(precision), scale(scale), sign(sign) {
+            val = valueBytes;
+        // Ensure val is always exactly SQL_MAX_NUMERIC_LEN bytes
+        val.resize(SQL_MAX_NUMERIC_LEN, '\0');
+        }
 };
 
 // Struct to hold the DateTimeOffset structure
@@ -557,9 +562,21 @@ SQLRETURN BindParameters(SQLHANDLE hStmt, const py::list& params,
                 decimalPtr->sign = decimalParam.sign;
                 // Convert the integer decimalParam.val to char array
                 std::memset(static_cast<void*>(decimalPtr->val), 0, sizeof(decimalPtr->val));
-                std::memcpy(static_cast<void*>(decimalPtr->val),
-			    reinterpret_cast<char*>(&decimalParam.val),
-                            sizeof(decimalParam.val));
+                // std::memcpy(static_cast<void*>(decimalPtr->val),
+			    // reinterpret_cast<char*>(&decimalParam.val),
+                //             sizeof(decimalParam.val));
+                size_t src_len = decimalParam.val.size();
+    if (src_len > sizeof(decimalPtr->val)) {
+        // Defensive: should never happen if Python side ensures 16 bytes; but guard anyway
+        ThrowStdException("Numeric value byte buffer too large for SQL_NUMERIC_STRUCT (paramIndex " + std::to_string(paramIndex) + ")");
+    }
+    if (src_len > 0) {
+        std::memcpy(static_cast<void*>(decimalPtr->val),
+                    static_cast<const void*>(decimalParam.val.data()),
+                    src_len);
+    }
+    //print the data received from python
+    LOG("Numeric parameter val bytes: {}", decimalPtr->val);
                 dataPtr = static_cast<void*>(decimalPtr);
                 break;
             }
@@ -3794,7 +3811,7 @@ PYBIND11_MODULE(ddbc_bindings, m) {
     // Define numeric data class
     py::class_<NumericData>(m, "NumericData")
         .def(py::init<>())
-        .def(py::init<SQLCHAR, SQLSCHAR, SQLCHAR, std::uint64_t>())
+        .def(py::init<SQLCHAR, SQLSCHAR, SQLCHAR, const std::string&>())
         .def_readwrite("precision", &NumericData::precision)
         .def_readwrite("scale", &NumericData::scale)
         .def_readwrite("sign", &NumericData::sign)