Apply fixes from copilot review

Author: dlevy-msft-sql

mssql_python/constants.py

@@ -501,14 +501,4 @@ def get_attribute_set_timing(attribute):
     "packetsize": "PacketSize",
 }
 
-def test_cursor_description(cursor):
-    """Test cursor description"""
-    cursor.execute("SELECT database_id, name FROM sys.databases;")
-    desc = cursor.description
-    expected_description = [
-        ("database_id", 4, None, 10, 10, 0, False),  # SQL_INTEGER
-        ("name", -9, None, 128, 128, 0, False),  # SQL_WVARCHAR
-    ]
-    assert len(desc) == len(expected_description), "Description length mismatch"
-    for desc, expected in zip(desc, expected_description):
-        assert desc == expected, f"Description mismatch: {desc} != {expected}"
+# (Function removed; no replacement needed)

mssql_python/cursor.py

@@ -955,7 +955,7 @@ def _map_data_type(self, sql_type):
             ddbc_sql_const.SQL_LONGVARBINARY.value: bytes,
             ddbc_sql_const.SQL_GUID.value: uuid.UUID,
             ddbc_sql_const.SQL_SS_UDT.value: bytes,  # UDTs mapped to bytes
-            ddbc_sql_const.SQL_XML.value: xml,  # XML mapped to str
+            ddbc_sql_const.SQL_XML.value: str,  # XML mapped to str
             ddbc_sql_const.SQL_DATETIME2.value: datetime.datetime,
             ddbc_sql_const.SQL_SMALLDATETIME.value: datetime.datetime,
             ddbc_sql_const.SQL_DATETIMEOFFSET.value: datetime.datetime,

tests/test_004_cursor.py

@@ -999,7 +999,7 @@ def test_fetchall(cursor):
 
 
 def test_fetchall_lob(cursor):
-    """Test fetching all rows"""
+    """Test fetching all rows with LOB columns"""
     cursor.execute("SELECT * FROM #pytest_all_data_types")
     rows = cursor.fetchall()
     assert isinstance(rows, list), "fetchall should return a list"
@@ -13269,13 +13269,6 @@ def test_xml_malformed_input(cursor, db_connection):
 MULTIPOINT_WKT = "MULTIPOINT((-122.34900 47.65100), (-122.11100 47.67700))"
 COLLECTION_WKT = "GEOMETRYCOLLECTION(POINT(-122.34900 47.65100))"
 
-# Large geography for LOB testing
-LARGE_POLYGON_WKT = (
-    "POLYGON(("
-    + ", ".join([f"{-122.5 + i*0.001} {47.5 + i*0.001}" for i in range(5000)])
-    + ", -122.5 47.5))"
-)
-
 
 def test_geography_basic_insert_fetch(cursor, db_connection):
     """Test insert and fetch of a basic geography Point value."""