Skip to content

Commit 621b1cc

Browse files
committed
resolving copilot comments
1 parent 3db0775 commit 621b1cc

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

mssql_python/pybind/ddbc_bindings.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2992,9 +2992,6 @@ SQLRETURN FetchBatchData(SQLHSTMT hStmt, ColumnBuffers& buffers, py::list& colum
29922992
}
29932993
case SQL_GUID: {
29942994
SQLGUID* guidValue = &buffers.guidBuffers[col - 1][i];
2995-
// We already have the raw bytes from SQL Server in the SQLGUID struct.
2996-
// We do not need to perform any additional reordering here, as the C++
2997-
// SQLGUID struct is already laid out in the non-standard SQL Server byte order.
29982995
std::vector<char> guid_bytes(16);
29992996
std::memcpy(guid_bytes.data(), guidValue, sizeof(SQLGUID));
30002997

tests/test_004_cursor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10267,7 +10267,7 @@ def test_insert_multiple_uuids(cursor, db_connection):
1026710267
db_connection.commit()
1026810268

1026910269
def test_uuid_insert_with_none(cursor, db_connection):
10270-
"""Test that inserting None into a UUID column raises an error (or is handled)."""
10270+
"""Test that inserting None into a UUID column results in a NULL value and is handled correctly."""
1027110271
table_name = "#pytest_uuid_none"
1027210272
try:
1027310273
cursor.execute(f"DROP TABLE IF EXISTS {table_name}")

0 commit comments

Comments
 (0)