Resolving comments

Author: jahnvi480

mssql_python/__init__.py

@@ -53,29 +53,36 @@
 SQL_WMETADATA = -99
 
 # Export connection attribute constants for set_attr()
+# NOTE: Some attributes are only supported when using an ODBC Driver Manager.
+# Attributes marked with [NO-OP] are not supported directly by the SQL Server ODBC driver
+# and will have no effect in this implementation.
+
 SQL_ATTR_ACCESS_MODE = ConstantsDDBC.SQL_ATTR_ACCESS_MODE.value
 SQL_ATTR_AUTOCOMMIT = ConstantsDDBC.SQL_ATTR_AUTOCOMMIT.value
 SQL_ATTR_CONNECTION_TIMEOUT = ConstantsDDBC.SQL_ATTR_CONNECTION_TIMEOUT.value
 SQL_ATTR_CURRENT_CATALOG = ConstantsDDBC.SQL_ATTR_CURRENT_CATALOG.value
 SQL_ATTR_LOGIN_TIMEOUT = ConstantsDDBC.SQL_ATTR_LOGIN_TIMEOUT.value
 SQL_ATTR_ODBC_CURSORS = ConstantsDDBC.SQL_ATTR_ODBC_CURSORS.value
 SQL_ATTR_PACKET_SIZE = ConstantsDDBC.SQL_ATTR_PACKET_SIZE.value
-SQL_ATTR_QUIET_MODE = ConstantsDDBC.SQL_ATTR_QUIET_MODE.value
 SQL_ATTR_TXN_ISOLATION = ConstantsDDBC.SQL_ATTR_TXN_ISOLATION.value
-SQL_ATTR_TRACE = ConstantsDDBC.SQL_ATTR_TRACE.value
-SQL_ATTR_TRACEFILE = ConstantsDDBC.SQL_ATTR_TRACEFILE.value
-SQL_ATTR_TRANSLATE_LIB = ConstantsDDBC.SQL_ATTR_TRANSLATE_LIB.value
-SQL_ATTR_TRANSLATE_OPTION = ConstantsDDBC.SQL_ATTR_TRANSLATE_OPTION.value
-SQL_ATTR_CONNECTION_POOLING = ConstantsDDBC.SQL_ATTR_CONNECTION_POOLING.value
-SQL_ATTR_CP_MATCH = ConstantsDDBC.SQL_ATTR_CP_MATCH.value
-SQL_ATTR_ASYNC_ENABLE = ConstantsDDBC.SQL_ATTR_ASYNC_ENABLE.value
-SQL_ATTR_ENLIST_IN_DTC = ConstantsDDBC.SQL_ATTR_ENLIST_IN_DTC.value
-SQL_ATTR_ENLIST_IN_XA = ConstantsDDBC.SQL_ATTR_ENLIST_IN_XA.value
-SQL_ATTR_CONNECTION_DEAD = ConstantsDDBC.SQL_ATTR_CONNECTION_DEAD.value
-SQL_ATTR_SERVER_NAME = ConstantsDDBC.SQL_ATTR_SERVER_NAME.value
-SQL_ATTR_ASYNC_DBC_FUNCTIONS_ENABLE = ConstantsDDBC.SQL_ATTR_ASYNC_DBC_FUNCTIONS_ENABLE.value
-SQL_ATTR_ASYNC_DBC_EVENT = ConstantsDDBC.SQL_ATTR_ASYNC_DBC_EVENT.value
-SQL_ATTR_RESET_CONNECTION = ConstantsDDBC.SQL_ATTR_RESET_CONNECTION.value
+
+# The following attributes are [NO-OP] in this implementation (require Driver Manager):
+# SQL_ATTR_QUIET_MODE
+# SQL_ATTR_TRACE
+# SQL_ATTR_TRACEFILE
+# SQL_ATTR_TRANSLATE_LIB
+# SQL_ATTR_TRANSLATE_OPTION
+# SQL_ATTR_CONNECTION_POOLING
+# SQL_ATTR_CP_MATCH
+# SQL_ATTR_ASYNC_ENABLE
+# SQL_ATTR_ENLIST_IN_DTC
+# SQL_ATTR_ENLIST_IN_XA
+# SQL_ATTR_CONNECTION_DEAD
+# SQL_ATTR_ASYNC_DBC_FUNCTIONS_ENABLE
+# SQL_ATTR_ASYNC_DBC_EVENT
+# SQL_ATTR_SERVER_NAME
+# SQL_ATTR_RESET_CONNECTION
+# SQL_RESET_CONNECTION_YES
 
 # Transaction Isolation Level Constants
 SQL_TXN_READ_UNCOMMITTED = ConstantsDDBC.SQL_TXN_READ_UNCOMMITTED.value
@@ -87,17 +94,11 @@
 SQL_MODE_READ_WRITE = ConstantsDDBC.SQL_MODE_READ_WRITE.value
 SQL_MODE_READ_ONLY = ConstantsDDBC.SQL_MODE_READ_ONLY.value
 
-# Connection Dead Constants
-SQL_CD_TRUE = ConstantsDDBC.SQL_CD_TRUE.value
-SQL_CD_FALSE = ConstantsDDBC.SQL_CD_FALSE.value
-
 # ODBC Cursors Constants
 SQL_CUR_USE_IF_NEEDED = ConstantsDDBC.SQL_CUR_USE_IF_NEEDED.value
 SQL_CUR_USE_ODBC = ConstantsDDBC.SQL_CUR_USE_ODBC.value
 SQL_CUR_USE_DRIVER = ConstantsDDBC.SQL_CUR_USE_DRIVER.value
 
-# Reset Connection Constants
-SQL_RESET_CONNECTION_YES = ConstantsDDBC.SQL_RESET_CONNECTION_YES.value
 
 # GLOBALS
 # Read-Only

mssql_python/connection.py

@@ -544,30 +544,23 @@ def set_attr(self, attribute, value):
         Example:
             >>> conn.set_attr(SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF)
             >>> conn.set_attr(SQL_ATTR_TXN_ISOLATION, SQL_TXN_READ_COMMITTED)
-
-        Note:
-            This method is compatible with pyodbc's set_attr functionality.
-            Attribute values must be within valid SQLUINTEGER range (0 to 4294967295).
         """
         if self._closed:
             raise InterfaceError("Cannot set attribute on closed connection", "Connection is closed")
 
-        # Validate attribute type and range for SQLUINTEGER compatibility
+        # Validate attribute type and range
         if not isinstance(attribute, int) or attribute < 0:
             raise ProgrammingError("Connection attribute must be a non-negative integer", f"Invalid attribute: {attribute}")
 
-        # Validate attribute is within SQLUINTEGER range
-        if attribute > 4294967295:  # 2^32 - 1
-            raise ProgrammingError("Connection attribute must be within SQLUINTEGER range (0-4294967295)", f"Attribute out of range: {attribute}")
-
-        # Validate value type - must be integer, bytes, or bytearray
-        if not isinstance(value, (int, bytes, bytearray)):
-            raise ProgrammingError("Attribute value must be an integer, bytes, or bytearray", f"Invalid value type: {type(value)}")
+        # Validate value type - must be integer, bytes, bytearray, or string
+        if not isinstance(value, (int, bytes, bytearray, str)):
+            raise ProgrammingError("Attribute value must be an integer, bytes, bytearray, or string", 
+                                  f"Invalid value type: {type(value)}")
 
-        # For integer values, validate SQLUINTEGER range
+        # For integer values
         if isinstance(value, int):
-            if value < 0 or value > 4294967295:  # 2^32 - 1
-                raise ProgrammingError("Attribute value out of range for SQLUINTEGER (0-4294967295)", f"Value out of range: {value}")
+            if value < 0:
+                raise ProgrammingError(f"Attribute value must be non-negative", f"Invalid value: {value}")
 
         # Sanitize user input for security
         try: