Resolving comments

Author: jahnvi480

mssql_python/connection.py

@@ -32,13 +32,9 @@
     'utf-16be'
 ])
 
-# Cache for encoding validation to improve performance
-# Using a simple dict instead of lru_cache for module-level caching
-_ENCODING_VALIDATION_CACHE = {}
-_CACHE_MAX_SIZE = 100  # Limit cache size to prevent memory bloat
+_CACHE_MAX_SIZE = 128  # Limit cache size to avoid excessive memory usage
 
-
-@lru_cache(maxsize=128)
+@lru_cache(maxsize=_CACHE_MAX_SIZE)
 def _validate_encoding(encoding: str) -> bool:
     """
     Cached encoding validation using codecs.lookup().

tests/conftest.py

@@ -18,7 +18,7 @@ def pytest_configure(config):
 
 @pytest.fixture(scope='session')
 def conn_str():
-    conn_str = "Server=tcp:DESKTOP-1A982SC,1433;Database=master;TrustServerCertificate=yes;Trusted_Connection=yes;"
+    conn_str = os.getenv('DB_CONNECTION_STRING')
     return conn_str
 
 @pytest.fixture(scope="module")

tests/test_003_connection.py

@@ -550,7 +550,6 @@ def test_setencoding_none_parameters(db_connection):
 
 def test_setencoding_invalid_encoding(db_connection):
     """Test setencoding with invalid encoding."""
-    from mssql_python.exceptions import ProgrammingError
 
     with pytest.raises(ProgrammingError) as exc_info:
         db_connection.setencoding(encoding='invalid-encoding-name')
@@ -560,7 +559,6 @@ def test_setencoding_invalid_encoding(db_connection):
 
 def test_setencoding_invalid_ctype(db_connection):
     """Test setencoding with invalid ctype."""
-    from mssql_python.exceptions import ProgrammingError
 
     with pytest.raises(ProgrammingError) as exc_info:
         db_connection.setencoding(encoding='utf-8', ctype=999)
@@ -570,7 +568,6 @@ def test_setencoding_invalid_ctype(db_connection):
 
 def test_setencoding_closed_connection(conn_str):
     """Test setencoding on closed connection."""
-    from mssql_python.exceptions import InterfaceError
 
     temp_conn = connect(conn_str)
     temp_conn.close()
@@ -827,20 +824,8 @@ def test_setencoding_with_explicit_ctype_sql_wchar(conn_str):
     finally:
         conn.close()
 
-def test_setencoding_invalid_encoding(conn_str):
-    """Test setencoding with invalid encoding raises ProgrammingError"""
-    from mssql_python.exceptions import ProgrammingError
-    
-    conn = connect(conn_str)
-    try:
-        with pytest.raises(ProgrammingError, match="Unsupported encoding"):
-            conn.setencoding('invalid-encoding-name')
-    finally:
-        conn.close()
-
-def test_setencoding_invalid_ctype(conn_str):
+def test_setencoding_invalid_ctype_error(conn_str):
     """Test setencoding with invalid ctype raises ProgrammingError"""
-    from mssql_python.exceptions import ProgrammingError
 
     conn = connect(conn_str)
     try:
@@ -849,14 +834,6 @@ def test_setencoding_invalid_ctype(conn_str):
     finally:
         conn.close()
 
-def test_setencoding_closed_connection(conn_str):
-    """Test setencoding on closed connection raises InterfaceError"""
-    conn = connect(conn_str)
-    conn.close()
-    
-    with pytest.raises(InterfaceError, match="Connection is closed"):
-        conn.setencoding('utf-8')
-
 def test_setencoding_case_insensitive_encoding(conn_str):
     """Test setencoding with case variations"""
     conn = connect(conn_str)