Commit fb7b5c3
authored
FIX: Connection String Param for Authentication (#368)
### Work Item / Issue Reference
<!--
IMPORTANT: Please follow the PR template guidelines below.
For mssql-python maintainers: Insert your ADO Work Item ID below (e.g.
AB#37452)
For external contributors: Insert Github Issue number below (e.g. #149)
Only one reference is required - either GitHub issue OR ADO Work Item.
-->
<!-- mssql-python maintainers: ADO Work Item -->
>
[AB#40945](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/40945)
<!-- External contributors: GitHub Issue -->
> GitHub Issue: #362
-------------------------------------------------------------------
### Summary
This pull request updates the logic for filtering sensitive parameters
in the authentication module. The main change is that the function now
removes `Trusted_Connection` instead of `Encrypt` and
`TrustServerCertificate`, and the corresponding test has been updated to
reflect this new behavior.
Sensitive parameter filtering update:
* In `mssql_python/auth.py`, the `remove_sensitive_params` function now
excludes `trusted_connection` instead of `encrypt` and
`trustservercertificate` when filtering parameters.
Test updates for new filtering logic:
* In `tests/test_008_auth.py`, the test for `remove_sensitive_params`
has been updated to expect that `Encrypt` and `TrustServerCertificate`
are no longer removed, while `Trusted_Connection` is now excluded.1 parent 907b364 commit fb7b5c3
2 files changed
+5
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | | - | |
| 168 | + | |
170 | 169 | | |
171 | 170 | | |
172 | 171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
| 312 | + | |
312 | 313 | | |
313 | 314 | | |
314 | 315 | | |
315 | 316 | | |
316 | 317 | | |
317 | 318 | | |
318 | 319 | | |
319 | | - | |
320 | | - | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
321 | 323 | | |
322 | 324 | | |
323 | 325 | | |
| |||
0 commit comments