Merge pull request #849 from microsoft/845

Tyriar · web-flow · commit 7c34e584378c · 2025-12-30T03:55:02.000-08:00
Pass error details in apple spawn exception
diff --git a/src/unix/pty.cc b/src/unix/pty.cc
@@ -370,7 +370,7 @@ Napi::Value PtyFork(const Napi::CallbackInfo& info) {
   int err = -1;
   pty_posix_spawn(argv, env, term, &winp, &master, &pid, &err);
   if (err != 0) {
-    throw Napi::Error::New(napiEnv, "posix_spawnp failed.");
+    throw Napi::Error::New(napiEnv, std::string("pty_posix_spawn failed with error: ") + std::to_string(err) + " (" + strerror(err) + ")");
   }
   if (pty_nonblock(master) == -1) {
     throw Napi::Error::New(napiEnv, "Could not set master fd to nonblocking.");

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ Napi::Value PtyFork(const Napi::CallbackInfo& info) {`
`370`	`370`	`int err = -1;`
`371`	`371`	`pty_posix_spawn(argv, env, term, &winp, &master, &pid, &err);`
`372`	`372`	`if (err != 0) {`
`373`		`- throw Napi::Error::New(napiEnv, "posix_spawnp failed.");`
	`373`	`+ throw Napi::Error::New(napiEnv, std::string("pty_posix_spawn failed with error: ") + std::to_string(err) + " (" + strerror(err) + ")");`
`374`	`374`	`}`
`375`	`375`	`if (pty_nonblock(master) == -1) {`
`376`	`376`	`throw Napi::Error::New(napiEnv, "Could not set master fd to nonblocking.");`