Commit 854330c
authored
.Net: Remove the HTTPS validations in AzureClientCore (#11943)
### Remove HTTPS validation from `AzureClientCore` class.
We are redirecting requests internally to inject API keys securely and
keep track of token usage in a transparent way, but this involves a YARP
proxy in between certain applications and Azure OpenAI. That proxy,
being internal behind our servers, doesn't use HTTPS and it doesn't need
to use it either. The current version of Semantic Kernel throws an error
when using a HTTP endpoint. Current fixes involve a lot of additional
steps and going out of the server to come back in through our azure
gateway or adding self-generated certificates and bypassing SSL errors,
etc... This fix would be very helpful.
* Remove the `Verify.StartsWith` validation for the `endpoint` parameter
in the constructors of `AzureClientCore` class.
* Remove the test case
`ConstructorWithInvalidEndpointShouldThrowArgumentException` from
`AzureClientCoreTests` class.
* Ensure the remaining test cases do not enforce HTTPS validation.1 parent 1602409 commit 854330c
File tree
2 files changed
+0
-15
lines changed- dotnet/src/Connectors
- Connectors.AzureOpenAI.UnitTests/Core
- Connectors.AzureOpenAI/Core
2 files changed
+0
-15
lines changedLines changed: 0 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 46 | | |
60 | 47 | | |
61 | 48 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | 55 | | |
57 | 56 | | |
58 | 57 | | |
| |||
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
88 | | - | |
89 | 87 | | |
90 | 88 | | |
91 | 89 | | |
| |||
0 commit comments