fix: preserve Poetry command working directory

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480

Author: edvilme

src/managers/poetry/poetryPackageManager.ts

@@ -82,7 +82,7 @@ export class PoetryPackageManager implements PackageManager, Disposable {
         }
 
         try {
-            await this.runPoetryManage(environment, { install: toInstall, uninstall: toUninstall });
+            await this.runPoetryManage({ install: toInstall, uninstall: toUninstall });
             await updatePackagesAndNotify(this, environment, this.packages.get(environment.envId.id), (changes) => {
                 this._onDidChangePackages.fire({ environment, manager: this, changes });
             });
@@ -174,10 +174,7 @@ export class PoetryPackageManager implements PackageManager, Disposable {
         this.packages.clear();
     }
 
-    private async runPoetryManage(
-        environment: PythonEnvironment,
-        options: { install?: string[]; uninstall?: string[] },
-    ): Promise<void> {
+    private async runPoetryManage(options: { install?: string[]; uninstall?: string[] }): Promise<void> {
         const poetry = await getPoetry();
         if (!poetry) {
             throw new Error(
@@ -186,13 +183,10 @@ export class PoetryPackageManager implements PackageManager, Disposable {
                 ),
             );
         }
-        const cwd = await this.getPoetryCwd(environment);
-
         // Handle uninstalls first
         if (options.uninstall && options.uninstall.length > 0) {
             const removeCmd = new PoetryRemoveCommand({
                 pythonExecutable: poetry,
-                cwd,
                 log: this.log,
             });
             const packages = parsePackageSpecs(options.uninstall);
@@ -206,7 +200,6 @@ export class PoetryPackageManager implements PackageManager, Disposable {
         if (options.install && options.install.length > 0) {
             const addCmd = new PoetryAddCommand({
                 pythonExecutable: poetry,
-                cwd,
                 log: this.log,
             });
             const packages = parsePackageSpecs(options.install);
@@ -237,16 +230,14 @@ export class PoetryPackageManager implements PackageManager, Disposable {
         return (data ?? []).map((pkg) => this.api.createPackageItem(pkg, environment, this));
     }
 
-    async getDirectPackageNames(environment: PythonEnvironment): Promise<Set<string> | undefined> {
+    async getDirectPackageNames(_environment: PythonEnvironment): Promise<Set<string> | undefined> {
         try {
             const poetry = await getPoetry();
             if (!poetry) {
                 return undefined;
             }
-            const cwd = await this.getPoetryCwd(environment);
             const showTopLevelCmd = new PoetryShowTopLevelCommand({
                 pythonExecutable: poetry,
-                cwd,
                 log: this.log,
             });
             return await showTopLevelCmd.execute();

src/test/managers/poetry/poetryPackageManager.unit.test.ts

@@ -0,0 +1,67 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+import assert from 'assert';
+import * as path from 'path';
+import * as sinon from 'sinon';
+import { LogOutputChannel, Uri } from 'vscode';
+import { PythonEnvironmentApi } from '../../../api';
+import * as windowApis from '../../../common/window.apis';
+import * as packageChanges from '../../../managers/common/packageChanges';
+import { PoetryPackageManager } from '../../../managers/poetry/poetryPackageManager';
+import { PoetryManager } from '../../../managers/poetry/poetryManager';
+import * as poetryUtils from '../../../managers/poetry/poetryUtils';
+import * as runPoetryModule from '../../../managers/poetry/commands/runPoetry';
+import { createMockPythonEnvironment } from '../../mocks/pythonEnvironment';
+
+suite('PoetryPackageManager', () => {
+    const environment = createMockPythonEnvironment({
+        envPath: path.join(process.cwd(), '.venv'),
+        managerId: 'ms-python.python:poetry',
+    });
+    let runPoetryStub: sinon.SinonStub;
+    let manager: PoetryPackageManager;
+
+    setup(() => {
+        const api = {
+            getPythonProjects: () => [
+                {
+                    name: 'project',
+                    uri: Uri.file(path.join(process.cwd(), 'project', 'pyproject.toml')),
+                },
+            ],
+        } as unknown as PythonEnvironmentApi;
+        const log = {
+            append: sinon.stub(),
+            error: sinon.stub(),
+            info: sinon.stub(),
+            show: sinon.stub(),
+        } as unknown as LogOutputChannel;
+
+        sinon.stub(poetryUtils, 'getPoetry').resolves('poetry');
+        sinon.stub(windowApis, 'withProgress').callsFake((_options, task) => task({} as never, {} as never));
+        sinon.stub(packageChanges, 'updatePackagesAndNotify').resolves([]);
+        runPoetryStub = sinon.stub(runPoetryModule, 'runPoetry').resolves('');
+        manager = new PoetryPackageManager(api, log, {} as PoetryManager);
+    });
+
+    teardown(() => {
+        manager.dispose();
+        sinon.restore();
+    });
+
+    test('package management inherits the process working directory', async () => {
+        await manager.manage(environment, { install: ['requests'], uninstall: ['flask'] });
+
+        assert.strictEqual(runPoetryStub.callCount, 2);
+        assert.strictEqual(runPoetryStub.firstCall.args[1], undefined);
+        assert.strictEqual(runPoetryStub.secondCall.args[1], undefined);
+    });
+
+    test('direct package listing inherits the process working directory', async () => {
+        await manager.getDirectPackageNames(environment);
+
+        assert.strictEqual(runPoetryStub.callCount, 1);
+        assert.strictEqual(runPoetryStub.firstCall.args[1], undefined);
+    });
+});