Replace parsePipList with parsePipListJson for better integration

Author: edvilme

package-lock.json

@@ -582,6 +582,11 @@ export interface Package extends PackageInfo {
      * The ID of the package.
      */
     readonly pkgId: PackageId;
+
+    /**
+     * Indicates whether the package is a transitive dependency (i.e., installed as a dependency of another package rather than directly by the user).
+     */
+    isTransitive?: boolean;
 }
 
 /**

src/api.ts

@@ -9,29 +9,22 @@ export function isValidVersion(version: string): boolean {
         version,
     );
 }
-export function parsePipList(data: string): PipPackage[] {
-    const collection: PipPackage[] = [];
 
-    const lines = data.split('\n').splice(2);
-    for (let line of lines) {
-        if (line.trim() === '' || line.startsWith('Package') || line.startsWith('----') || line.startsWith('[')) {
-            continue;
-        }
-        const parts = line.split(' ').filter((e) => e);
-        if (parts.length === 2) {
-            const name = parts[0].trim();
-            const version = parts[1].trim();
-            if (!isValidVersion(version)) {
-                continue;
-            }
-            const pkg = {
-                name,
-                version,
-                displayName: name,
-                description: version,
-            };
-            collection.push(pkg);
+export function parsePipListJson(data: string): PipPackage[] {
+    try {
+        const json = JSON.parse(data);
+        if (Array.isArray(json)) {
+            return json
+                .filter((item) => typeof item.name === 'string' && typeof item.version === 'string')
+                .map(({ name, version }) => ({
+                    name,
+                    version,
+                    displayName: name,
+                    description: version,
+                }));
         }
+    } catch {
+        // If JSON parsing fails, return an empty array
     }
-    return collection;
+    return [];
 }

src/managers/builtin/pipListUtils.ts

@@ -23,7 +23,7 @@ import {
 } from '../common/nativePythonFinder';
 import { shortVersion, sortEnvironments } from '../common/utils';
 import { runPython, runUV, shouldUseUv } from './helpers';
-import { parsePipList, PipPackage } from './pipListUtils';
+import { parsePipListJson, PipPackage } from './pipListUtils';
 
 const PIXI_EXTENSION_ID = 'renan-r-santos.pixi-code';
 const PIXI_RECOMMEND_DONT_ASK_KEY = 'pixi-extension-recommend-dont-ask';
@@ -190,7 +190,7 @@ async function refreshPipPackagesRaw(environment: PythonEnvironment, log?: LogOu
     const useUv = await shouldUseUv(log, environment.environmentPath.fsPath);
     if (useUv) {
         return await runUV(
-            ['pip', 'list', '--python', environment.execInfo.run.executable],
+            ['pip', 'list', '--python', environment.execInfo.run.executable, '--format=json'],
             undefined,
             log,
             undefined,
@@ -200,7 +200,7 @@ async function refreshPipPackagesRaw(environment: PythonEnvironment, log?: LogOu
     try {
         return await runPython(
             environment.execInfo.run.executable,
-            ['-m', 'pip', 'list'],
+            ['-m', 'pip', 'list', '--format=json'],
             undefined,
             log,
             undefined,
@@ -222,20 +222,19 @@ export async function refreshPipPackages(
 ): Promise<PipPackage[] | undefined> {
     let data: string;
     try {
+        const loadPackages = async () => refreshPipPackagesRaw(environment, log);
         if (options?.showProgress) {
             data = await withProgress(
                 {
                     location: ProgressLocation.Notification,
                 },
-                async () => {
-                    return await refreshPipPackagesRaw(environment, log);
-                },
+                loadPackages,
             );
         } else {
-            data = await refreshPipPackagesRaw(environment, log);
+            data = await loadPackages();
         }
 
-        return parsePipList(data);
+        return parsePipListJson(data);
     } catch (e) {
         log?.error('Error refreshing packages', e);
         showErrorMessageWithLogs(SysManagerStrings.packageRefreshError, log);

src/managers/builtin/utils.ts

@@ -1,7 +1,7 @@
 import assert from 'assert';
 import * as fs from 'fs-extra';
 import * as path from 'path';
-import { parsePipList } from '../../../managers/builtin/pipListUtils';
+import { parsePipListJson } from '../../../managers/builtin/pipListUtils';
 import { EXTENSION_TEST_ROOT } from '../../constants';
 
 const TEST_DATA_ROOT = path.join(EXTENSION_TEST_ROOT, 'managers', 'builtin');
@@ -16,7 +16,7 @@ suite('Pip List Parser tests', () => {
                 await fs.readFile(path.join(TEST_DATA_ROOT, `${testName}.expected.json`), 'utf8'),
             );
 
-            const actualPackages = parsePipList(pipListOutput);
+            const actualPackages = parsePipListJson(pipListOutput);
 
             assert.equal(actualPackages.length, expected.packages.length, 'Unexpected number of packages');
             actualPackages.forEach((actualPackage) => {