Renaming a session requires reload

[bamurtaugh]

Only seems to happen in VS Code editor window rather than Agents window:

• Right click a chat session in list, rename, set a new name, enter
• ❓ New name doesn't appear
• I have to reload VS Code for the new name to appear

[bamurtaugh]

I also found that the new name is lost if I fork the session:

• Click on one of my renamed sessions
• Fork it
• ❓ The session reverts to its previous name, and the Forked: ... title of the forked session is based on the previous name

[almassolarenrgi]

Only seems to happen in VS Code editor window rather than Agents window:

• Right click a chat session in list, rename, set a new name, enter
• ❓ New name doesn't appear
• I have to reload VS Code for the new name to appear

_001508914769741218003884406884406+1 (305) 510-00

[almassolarenrgi]

Only seems to happen in VS Code editor window rather than Agents window:

• Right click a chat session in list, rename, set a new name, enter
• ❓ New name doesn't appear
• I have to reload VS Code for the new name to appeard5bc059e2fbdd14a8c5f2d10628d2ba7b3047e14https://github.com/waydabber/BetterDisplay/issues/5234https://github.com/liushuaiiu/nextjs.githttps://github.com/almassolarenrgi/turbo-octo-fiesta.gitgh repo clone almassolarenrgi/turbo-octo-fiestahttps://github.com/almassolarenrgi/turbo-octo-fiesta.gitcontent/issues/planning-and-tracking-with-projects/index.mdhttps://github.com/waydabber/BetterDisplay.wiki.git

[katipally]

PR #318667 addresses the reload requirement bug.

Root cause was two separate issues:

• Bug A (history sessions): refresh() only tracked newly added items, not updated ones. Title changes on history sessions never triggered _onDidChangeChatSessionItems. Fixed by detecting label changes via isEqual(), plus a new onDidChangeChatSessionTitle event on IChatService for history sessions.
• Bug B (persistence): renameChat() was calling setSessionTitle() (sync, in-memory only) instead of setChatSessionTitle() (async, writes to _chatSessionStore). On reload the old title returned because nothing was written to disk.

Note: The fork-session name revert mentioned by @bamurtaugh is a separate issue not covered by this PR.