From dea51058772b443a42302ab91e6d494f1333a7fa Mon Sep 17 00:00:00 2001 From: Anurag Yadav Date: Sun, 7 Jun 2026 20:29:22 +0530 Subject: [PATCH] fix: disable dropdown shows only relevant actions for workspace-enabled extensions When an extension is disabled globally but enabled for a workspace (EnabledWorkspace state), the Disable button dropdown incorrectly showed both 'Disable' and 'Disable (Workspace)' items. The 'Disable' (global) action should not appear because the extension is already disabled globally. Only 'Disable (Workspace)' is meaningful in this state. Fix by restricting DisableGloballyAction to only be enabled when the extension's enablement state is EnabledGlobally. Fixes #244138 --- .../workbench/contrib/extensions/browser/extensionsActions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts b/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts index 5c76cd31e95009..95cadf474b1fbb 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts @@ -1780,7 +1780,7 @@ export class DisableGloballyAction extends ExtensionAction { return; } this.enabled = this.extension.state === ExtensionState.Installed - && (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace) + && this.extension.enablementState === EnablementState.EnabledGlobally && this.extensionEnablementService.canChangeEnablement(this.extension.local); } }