Exclude box drawing chars from suffix terminal links#320325
Open
KTibow wants to merge 2 commits into
Open
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @anthonykim1Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates terminal link parsing to treat box-drawing characters as link delimiters (in addition to |), and expands tests to cover the new separator behavior.
Changes:
- Extend the suffix-path parsing regex to exclude Unicode box-drawing characters (
\u2500-\u257F) from terminal link paths. - Update an existing parsing test to validate behavior for both ASCII pipe (
|) and box-drawing vertical bar (\u2502) separators.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts | Extends an existing test to assert link parsing behavior with multiple separator characters. |
| src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts | Updates the suffix-path regex to stop links at box-drawing characters as well as ` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting terminal links with line/column suffixes, ASCII pipe is already treated as a path separator so borders like
|C:\repo\file.ts:10|link toC:\repo\file.tsinstead of including the border.This applies the same behavior to Unicode box-drawing characters. That keeps suffixed path parsing internally consistent for terminal UIs that draw borders with characters like U+2502, avoiding links such as
\u2502C:\repo\file.ts:10including the border character in the target path.Changes:
Validation:
git diff --checkI could not run the browser unit test locally because dependency installation is blocked in this environment: Playwright Chromium does not support ubuntu26.04-arm64, and
native-keymaprequires the missing system packagexkbfile. The commit hook was bypassed after human approval; CI should run the full validation.Disclosure: This PR was generated by GPT-5.5 with human oversight.