Try to fix Chat smoke test flake#320380
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in the Chat Sessions smoke tests by avoiding configuration writes from the smoketest extension (which can race with Copilot Chat’s configuration schema registration) and by pre-seeding the required settings via settings.json edits before the tests run.
Changes:
- Pre-configure required chat/Copilot settings via
settingsEditor.addUserSettings(...)to avoid configuration-schema races. - Re-enable the previously skipped “Copilot CLI session” and “Claude session” smoke tests.
- Remove runtime
workspace.getConfiguration().update(...)calls from the smoketest extension commands that open those sessions.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/areas/chat/chatSessions.test.ts | Writes required settings up-front and re-enables the Copilot CLI + Claude session smoke tests. |
| test/smoke/extensions/vscode-smoketest-ext-host/extension.js | Stops mutating settings at command execution time to avoid racing with Copilot Chat configuration schema registration. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
dmitrivMS
approved these changes
Jun 8, 2026
alexr00
commented
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.