Merge pull request #31 from microsoftgraph/fix-return-type-on-http-actions

Removed void return type from HTTP actions

Author: dan-silver

lib/graph-js-sdk-web.js

@@ -2239,8 +2239,8 @@ exports.cleanHeader = function(header, shouldStripCookie){
 
 },{}],13:[function(require,module,exports){
 module.exports={
-  "name": "msgraph-sdk-javascript",
-  "version": "0.3.1",
+  "name": "@microsoft/microsoft-graph-client",
+  "version": "0.3.2",
   "description": "Microsoft Graph Client Library",
   "main": "lib/src/index.js",
   "typings": "lib/src/index",

lib/src/GraphRequest.d.ts

@@ -25,14 +25,14 @@ export declare class GraphRequest {
     count(count: boolean): GraphRequest;
     responseType(responseType: string): GraphRequest;
     private addCsvQueryParamater(propertyName, propertyValue, additionalProperties);
-    delete(callback?: GraphRequestCallback): Promise<any> | void;
-    patch(content: any, callback?: GraphRequestCallback): Promise<any> | void;
-    post(content: any, callback?: GraphRequestCallback): Promise<any> | void;
-    put(content: any, callback?: GraphRequestCallback): Promise<any> | void;
-    create(content: any, callback?: GraphRequestCallback): Promise<any> | void;
-    update(content: any, callback?: GraphRequestCallback): Promise<any> | void;
-    del(callback?: GraphRequestCallback): Promise<any> | void;
-    get(callback?: GraphRequestCallback): Promise<any> | void;
+    delete(callback?: GraphRequestCallback): Promise<any>;
+    patch(content: any, callback?: GraphRequestCallback): Promise<any>;
+    post(content: any, callback?: GraphRequestCallback): Promise<any>;
+    put(content: any, callback?: GraphRequestCallback): Promise<any>;
+    create(content: any, callback?: GraphRequestCallback): Promise<any>;
+    update(content: any, callback?: GraphRequestCallback): Promise<any>;
+    del(callback?: GraphRequestCallback): Promise<any>;
+    get(callback?: GraphRequestCallback): Promise<any>;
     private routeResponseToPromise(requestBuilder);
     private routeResponseToCallback(requestBuilder, callback);
     private sendRequestAndRouteResponse(requestBuilder, callback?);

src/GraphRequest.ts

@@ -195,12 +195,12 @@ export class GraphRequest {
     }
 
 
-    delete(callback?:GraphRequestCallback):Promise<any>|void {
+    delete(callback?:GraphRequestCallback):Promise<any> {
         let url = this.buildFullUrl();
         return this.sendRequestAndRouteResponse(request.del(url), callback)
     }
 
-    patch(content:any, callback?:GraphRequestCallback):Promise<any>|void {
+    patch(content:any, callback?:GraphRequestCallback):Promise<any> {
         let url = this.buildFullUrl();
 
         return this.sendRequestAndRouteResponse(
@@ -211,7 +211,7 @@ export class GraphRequest {
         );
     }
 
-    post(content:any, callback?:GraphRequestCallback):Promise<any>|void {
+    post(content:any, callback?:GraphRequestCallback):Promise<any> {
         let url = this.buildFullUrl();
         return this.sendRequestAndRouteResponse(
             request
@@ -221,7 +221,7 @@ export class GraphRequest {
         );
     }
 
-    put(content:any, callback?:GraphRequestCallback):Promise<any>|void {
+    put(content:any, callback?:GraphRequestCallback):Promise<any> {
         let url = this.buildFullUrl();
         return this.sendRequestAndRouteResponse(
             request
@@ -234,20 +234,20 @@ export class GraphRequest {
 
     // request aliases
     // alias for post
-    create(content:any, callback?:GraphRequestCallback):Promise<any>|void {
+    create(content:any, callback?:GraphRequestCallback):Promise<any> {
         return this.post(content, callback);
     }
 
     // alias for patch
-    update(content:any, callback?:GraphRequestCallback):Promise<any>|void {
+    update(content:any, callback?:GraphRequestCallback):Promise<any> {
         return this.patch(content, callback);
     }
 
-    del(callback?:GraphRequestCallback):Promise<any>|void {
+    del(callback?:GraphRequestCallback):Promise<any> {
         return this.delete(callback);
     }
 
-    get(callback?:GraphRequestCallback):Promise<any>|void {
+    get(callback?:GraphRequestCallback):Promise<any> {
         let url = this.buildFullUrl();
         return this.sendRequestAndRouteResponse(
             request
@@ -288,7 +288,7 @@ export class GraphRequest {
      * Help method that's called from the final actions( .get(), .post(), etc.) that after making the request either invokes
      * routeResponseToCallback() or routeResponseToPromise()
      */
-    private sendRequestAndRouteResponse(requestBuilder:request.SuperAgentRequest, callback?:GraphRequestCallback):Promise<any>|void {
+    private sendRequestAndRouteResponse(requestBuilder:request.SuperAgentRequest, callback?:GraphRequestCallback):Promise<any> {
         // return a promise when Promises are supported and no callback was provided
         if (callback == null && typeof Promise !== "undefined") {
             return this.routeResponseToPromise(requestBuilder);