Auto generation of version file and fix review comments

Author: muthurathinam-m

.huskyrc

@@ -1,5 +1,5 @@
 {
 	"hooks": {
-		"pre-commit": "lint-staged && npm run lint && npm run test"
+		"pre-commit": "npm run pre-build && lint-staged && npm run lint && npm run test"
 	}
 }

README.md

@@ -57,7 +57,7 @@ Register your application to use Microsoft Graph API using one of the following
 
 The Microsoft Graph JavaScript Client Library has an adapter implementation ([ImplicitMSALAuthenticationProvider](src/ImplicitMSALAuthenticationProvider.ts)) for [MSAL](https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/lib/msal-core) (Microsoft Authentication Library) which takes care of getting the `accessToken`. MSAL library does not ship with this library, user has to include it externally (For including MSAL, refer [this](https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/lib/msal-core#installation)).
 
-> **Important Note:** MSAL is supported only for frontend applications, for server-side authentication you have to implement your own AuthenticationProvider. Refer implementing [Custom Authentication Provider](./docs/CustomAuthenticationProvider.md).
+> **Important Note:** MSAL is supported only for frontend applications, for server-side authentication you have to implement your own AuthenticationProvider. Learn how you can create a [Custom Authentication Provider](./docs/CustomAuthenticationProvider.md).
 
 #### Creating an instance of ImplicitMSALAuthenticationProvider in browser environment
 
@@ -101,7 +101,7 @@ import { ImplicitMSALAuthenticationProvider } from "./node_modules/@microsoft/mi
 // An Optional options for initializing the MSAL @see https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/MSAL-basics#configuration-options
 const msalConfig = {
 	auth: {
-		clientId: "your_client_id"; // Client Id of the registered application
+		clientId: "your_client_id", // Client Id of the registered application
 		redirectUri: "your_redirect_uri",
 	},
 };

docs/CreatingClientInstance.md

@@ -14,8 +14,20 @@ Library is shipped with one such authentication provider named [ImplicitMSALAuth
 
 ```typescript
 // Instantiating Client with ImplicitMSALAuthenticationProvider
+
+// An Optional options for initializing the MSAL @see https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/MSAL-basics#configuration-options
+const msalConfig = {
+	auth: {
+		clientId: <CLIENT_ID> // Client Id of the registered application
+	},
+};
+
+// Important Note: This library implements loginPopup and acquireTokenPopup flow, remember this while initializing the msal
+// Initialize the MSAL @see https://github.com/AzureAD/microsoft-authentication-library-for-js#1-instantiate-the-useragentapplication
+const msalInstance = new UserAgentApplication(msalConfig);
+const options = new MicrosoftGraph.MSALAuthenticationProviderOptions(<SCOPES>); // An array of graph scopes
 let clientOptions: ClientOptions = {
-    authProvider: new ImplicitMSALAuthenticationProvider(<CLIENT_ID>, <SCOPES>, <OPTIONS>)
+    authProvider: new ImplicitMSALAuthenticationProvider(msalInstance, options)
 };
 const client = Client.initWithMiddleware(clientOptions);
 ```

gulpfile.js

@@ -0,0 +1,30 @@
+const { series } = require("gulp");
+
+const licenseStr = `/**
+ * -------------------------------------------------------------------------------------------
+ * Copyright (c) Microsoft Corporation.  All Rights Reserved.  Licensed under the MIT License.
+ * See License in the project root for license information.
+ * -------------------------------------------------------------------------------------------
+ */
+`;
+
+const moduleHeader = `/**
+ * @module Version
+ */
+`;
+
+const versionFile = `${licenseStr}
+// THIS FILE IS AUTO GENERATED
+// ANY CHANGES WILL BE LOST DURING BUILD
+
+${moduleHeader}
+export const PACKAGE_VERSION = "[VERSION]";
+`;
+
+async function setVersion() {
+	var pkg = require("./package.json");
+	var fs = require("fs");
+	fs.writeFileSync("src/Version.ts", versionFile.replace("[VERSION]", pkg.version));
+}
+
+exports.setVersion = series(setVersion);