Skip to content

Commit 93342d2

Browse files
Resolved review comments
1 parent 8ee9df3 commit 93342d2

File tree

11 files changed

+42
-34
lines changed

11 files changed

+42
-34
lines changed

lib/graph-js-sdk-core.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/graph-js-sdk-web.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/Client.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ export declare class Client {
3737
* @public
3838
* @static
3939
* To create a client instance with the Client Options
40-
* @param {ClientOptions} options - The options object for initializing the client
40+
* @param {ClientOptions} clientOptions - The options object for initializing the client
4141
* @returns The Client instance
4242
*/
43-
static initWithMiddleware(options: ClientOptions): Client;
43+
static initWithMiddleware(clientOptions: ClientOptions): Client;
4444
/**
4545
* @public
4646
* Entry point to make requests

lib/src/Client.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/Client.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/GraphError.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@ export declare class GraphError {
2424
* @public
2525
* A member holding code i.e name of the error
2626
*/
27-
code: string;
27+
code: string | null;
2828
/**
2929
* @public
3030
* A member holding error message
3131
*/
32-
message: string;
32+
message: string | null;
3333
/**
3434
* @public
3535
* A member holding request-id i.e identifier of the request
3636
*/
37-
requestId: string;
37+
requestId: string | null;
3838
/**
3939
* @public
4040
* A member holding processed date and time of the request

lib/src/GraphRequest.js

Lines changed: 12 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/GraphRequest.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Client.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,12 @@ export class Client {
9494
* @public
9595
* @static
9696
* To create a client instance with the Client Options
97-
* @param {ClientOptions} options - The options object for initializing the client
97+
* @param {ClientOptions} clientOptions - The options object for initializing the client
9898
* @returns The Client instance
9999
*/
100-
public static initWithMiddleware(options: ClientOptions): Client {
100+
public static initWithMiddleware(clientOptions: ClientOptions): Client {
101101
try {
102-
return new Client(options);
102+
return new Client(clientOptions);
103103
} catch (error) {
104104
throw error;
105105
}

src/GraphError.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@ export class GraphError {
2929
* @public
3030
* A member holding code i.e name of the error
3131
*/
32-
public code: string;
32+
public code: string | null;
3333

3434
/**
3535
* @public
3636
* A member holding error message
3737
*/
38-
public message: string;
38+
public message: string | null;
3939

4040
/**
4141
* @public
4242
* A member holding request-id i.e identifier of the request
4343
*/
44-
public requestId: string;
44+
public requestId: string | null;
4545

4646
/**
4747
* @public

0 commit comments

Comments
 (0)