Update unit test

Switch to isomorphic fetch

Author: REDMOND\lahuey

lib/spec/core/responseHandling.d.ts

@@ -1 +1 @@
-import 'whatwg-fetch';
+import 'isomorphic-fetch';

lib/spec/core/responseHandling.js

@@ -1,5 +1,5 @@
 import { Promise } from 'es6-promise';
-import 'whatwg-fetch';
+import 'isomorphic-fetch';
 import { Options, URLComponents, GraphRequestCallback } from "./common";
 export declare class GraphRequest {
     config: Options;

lib/spec/core/responseHandling.js.map

@@ -13,16 +13,16 @@
     "@types/node": "^9.4.0",
     "browserify": "^13.1.0",
     "mocha": "^3.2.0",
-    "typescript": "^2.2.1",
-    "whatwg-fetch": "^2.0.3"
+    "typescript": "^2.2.1"
   },
   "scripts": {
     "build": "tsc && node node-browserify.js > lib/graph-js-sdk-web.js",
     "test": "mocha lib/spec/core",
     "test:types": "tsc --p spec/types && mocha spec/types"
   },
   "dependencies": {
-    "es6-promise": "^4.1.0"
+    "es6-promise": "^4.1.0",
+    "isomorphic-fetch": "^2.2.1"
   },
   "repository": {
     "type": "git",

lib/src/GraphRequest.d.ts

@@ -1,17 +1,17 @@
-import 'whatwg-fetch';
+import 'isomorphic-fetch';
 import {ResponseHandler} from "../../src/ResponseHandler"
 import {GraphError} from '../../src/common'
 
 import * as mocha from 'mocha'
 
 import * as assert from 'assert';
 
-const _200_SUPERAGENT_RES_BODY: any = { a: 1 }; 
-const _200_SUPERAGENT_RES_INIT: ResponseInit = { status: 200 };
-const _200_SUPERAGENT_RES: Response =
-    new Response(_200_SUPERAGENT_RES_BODY, _200_SUPERAGENT_RES_INIT);
+const _200_RES_BODY: any = { a: 1 }; 
+const _200_RES_INIT: ResponseInit = { status: 200 };
+const _200_RES: Response =
+    new Response(_200_RES_BODY, _200_RES_INIT);
 
-const _500_SUPERAGENT_RES_BODY: any = {
+const _500_RES_BODY: any = {
     error: {
         "code": "SearchEvents",
         "message": "The parameter $search is not currently supported on the Events resource.",
@@ -20,48 +20,40 @@ const _500_SUPERAGENT_RES_BODY: any = {
             "date": "2016-11-17T18:37:45"
         }
     }
-}; 
-const _500_SUPERAGENT_RES_INIT: ResponseInit = { status: 500 };
-const _500_SUPERAGENT_RES: Response =
-    new Response(_200_SUPERAGENT_RES_BODY, _200_SUPERAGENT_RES_INIT);
+};
 
-const error: Error = new Error();
-(error as any).statusCode = 404;
+const _500_RES_INIT: ResponseInit = { status: 500 };
+const _500_RES: Response =
+    new Response(_500_RES_BODY, _500_RES_INIT);
 
 describe('#handleResponse()', function() {
     it('passes through response to callback', function() {
-        ResponseHandler.init(_200_SUPERAGENT_RES, null, _200_SUPERAGENT_RES_BODY, (err:GraphError, res) => {
-            assert.equal(res, _200_SUPERAGENT_RES.body);
+        ResponseHandler.init(_200_RES, null, _200_RES_BODY, (err:GraphError, res) => {
+            assert.equal(res, _200_RES.body);
         });
     });
 
     it('200 response => err is null', function() {
-        ResponseHandler.init(_200_SUPERAGENT_RES, null, _200_SUPERAGENT_RES_BODY, (err:GraphError, res) => {
+        ResponseHandler.init(_200_RES, null, _200_RES_BODY, (err:GraphError, res) => {
             assert.equal(err, null);
         });
     });
 });
 
 describe('#ParseResponse()', function() {
     it('extracts code and request-id from the JSON body of 500 errors', function() {
-        ResponseHandler.init(_500_SUPERAGENT_RES, null, _500_SUPERAGENT_RES_BODY, (err:GraphError, res) => {
-            assert.equal(err.code, _500_SUPERAGENT_RES_BODY.error.code);
-            assert.equal(err.requestId, _500_SUPERAGENT_RES_BODY.error.innerError["request-id"]);
+        ResponseHandler.init(_500_RES, null, _500_RES_BODY, (err:GraphError, res) => {
+            assert.equal(err.code, _500_RES_BODY.error.code);
+            assert.equal(err.requestId, _500_RES_BODY.error.innerError["request-id"]);
         });
     });
 });
 
 describe('#ParseError()', function() {
-    it('500 error => res param in callback is null', function() {
+    it('res param in callback is null', function() {
         ResponseHandler.init(null, null, null, (err:GraphError, res) => {
             assert.equal(res, null);
+            assert.equal(err.statusCode, -1);
         });
     });
-
-    it('parses a 404 superagent error', function() {
-        let graphErr = ResponseHandler.ParseError(error);
-        ResponseHandler.init(null, null, null, (err:GraphError, res) => {
-            assert.equal(graphErr.statusCode, 404);
-        });        
-    })
 });

lib/src/GraphRequest.js

@@ -1,5 +1,5 @@
 import { Promise } from 'es6-promise'
-import 'whatwg-fetch';
+import 'isomorphic-fetch';
 
 import { Options, URLComponents, GraphError, oDataQueryNames, GraphRequestCallback } from "./common"
 import { ResponseHandler } from "./ResponseHandler"