Skip to content

Fix expectations with unknown status from silently passing #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkon merged 2 commits into from
Oct 14, 2025
Merged

Fix expectations with unknown status from silently passing #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae36c9b
Use ruby 3.4.7
mkon Oct 14, 2025
2498c53
Raise ArgumentError when the expected status does not exist
mkon Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.4.1
3.4.7
4 changes: 3 additions & 1 deletion lib/openapi_contracts/rspec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@

def with_http_status(status)
if status.is_a? Symbol
@status = Rack::Utils::SYMBOL_TO_STATUS_CODE[status]
@status = Rack::Utils::SYMBOL_TO_STATUS_CODE.fetch(status) do
raise ArgumentError, "Unknown status #{status.inspect}"
end
else
@status = status
end
Expand Down
8 changes: 8 additions & 0 deletions spec/integration/rspec_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@
it { is_expected.to match_openapi_doc(doc).with_http_status(:bad_request) }
end

context 'when using unsupported status' do
it {
expect {
expect(subject).to match_openapi_doc(doc).with_http_status(:does_not_exist_in_rack)
}.to raise_error(ArgumentError, 'Unknown status :does_not_exist_in_rack')
}
end

context 'when using dynamic paths' do
let(:path) { '/messages/ef278ab2' }
let(:response_json) do
Expand Down