Merge pull request #174 from yandex/fix/173-unhandled-rejections-q

Unhandled rejections should not force the subprocess to exit

Author: 1999

package-lock.json

@@ -81,6 +81,7 @@
     "mocha-teamcity-reporter": "^2.4.0",
     "mochawesome": "^3.0.2",
     "node-gyp": "^3.6.0",
+    "q": "^1.5.1",
     "sinon": "^6.0.0",
     "ts-node": "^7.0.0",
     "tslint": "^5.10.0",

package.json

@@ -22,13 +22,10 @@ import {
   applyRequires,
   applyTimeouts,
   randomId,
-  setProcessExitListeners,
 } from '../util';
 
 import applyExit from './options/exit';
 
-setProcessExitListeners();
-
 const argv = yargs
   .boolean('bail')
   .option('compilers', {

src/subprocess/runner.ts

@@ -152,6 +152,9 @@ echo $?
 echo 'TESTCASE: subprocess exits before sending an end message'
 test test/no-subprocess-end/index.js
 echo $?
+echo 'TESTCASE: unhandled rejections should not force subprocess to exit'
+test test/q-promises/index.js
+echo $?
 
 echo "Passes: $PASSES Failes: $FAILES"
 

test/index.sh

@@ -0,0 +1 @@
+Make sure that q-based promises do not force subprocess to exit

test/q-promises/README

@@ -0,0 +1,20 @@
+#!/usr/bin/env node
+
+const assert = require('assert');
+const sinon = require('sinon');
+
+const MochaParallelTests = require('../../dist/main/mocha').default;
+const { setProcessExitListeners } = require('../../dist/util');
+const SilentReporter = require('../util/silent-reporter');
+
+setProcessExitListeners();
+
+const onRunnerEnd = sinon.fake();
+const mocha = new MochaParallelTests;
+mocha.reporter(SilentReporter);
+mocha.addFile(`${__dirname}/index.spec.js`);
+mocha.run().on('end', onRunnerEnd);
+
+process.on('exit', () => {
+    assert.strictEqual(onRunnerEnd.callCount, 1, `runner "end" event occured wrong number of times: ${onRunnerEnd.callCount}`);
+});

test/q-promises/index.js

@@ -0,0 +1,7 @@
+const { reject } = require('q');
+
+describe('suite', function () {
+    it('case', function () {
+        reject(new Error('foo'));
+    });
+});