test: rework stateless server notification tests to use bundled client and assert log output

Author: bperhaps

mcp-test/src/test/java/io/modelcontextprotocol/server/HttpServletStatelessIntegrationTests.java

@@ -10,6 +10,12 @@
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.BiFunction;
 
+import org.slf4j.LoggerFactory;
+
+import ch.qos.logback.classic.Level;
+import ch.qos.logback.classic.Logger;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import ch.qos.logback.core.read.ListAppender;
 import io.modelcontextprotocol.client.McpClient;
 import io.modelcontextprotocol.client.transport.HttpClientStreamableHttpTransport;
 import io.modelcontextprotocol.common.McpTransportContext;
@@ -42,6 +48,8 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
 
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 import org.springframework.mock.web.MockHttpServletRequest;
 import org.springframework.mock.web.MockHttpServletResponse;
 import org.springframework.web.client.RestClient;
@@ -766,61 +774,65 @@ void testThrownMcpErrorAndJsonRpcError() throws Exception {
 	}
 
 	@Test
-	void testInitializedNotificationCallReturnsAccepted() throws Exception {
-		var mcpServer = McpServer.sync(mcpStatelessServerTransport)
-			.serverInfo("test-server", "1.0.0")
-			.capabilities(ServerCapabilities.builder().build())
-			.build();
-
-		McpSchema.JSONRPCNotification notification = new McpSchema.JSONRPCNotification(McpSchema.JSONRPC_VERSION,
-				McpSchema.METHOD_NOTIFICATION_INITIALIZED, null);
-
-		MockHttpServletRequest request = new MockHttpServletRequest("POST", CUSTOM_MESSAGE_ENDPOINT);
-		MockHttpServletResponse response = new MockHttpServletResponse();
-
-		byte[] content = JSON_MAPPER.writeValueAsBytes(notification);
-		request.setContent(content);
-		request.addHeader("Content-Type", "application/json");
-		request.addHeader("Content-Length", Integer.toString(content.length));
-		request.addHeader("Accept", APPLICATION_JSON + ", " + TEXT_EVENT_STREAM);
-		request.addHeader("Cache-Control", "no-cache");
-		request.addHeader(HttpHeaders.PROTOCOL_VERSION, ProtocolVersions.MCP_2025_03_26);
+	void testInitializedNotificationDoesNotLogWarn() {
+		Logger handlerLogger = (Logger) LoggerFactory
+			.getLogger("io.modelcontextprotocol.server.DefaultMcpStatelessServerHandler");
+		ListAppender<ILoggingEvent> logAppender = new ListAppender<>();
+		logAppender.start();
+		handlerLogger.addAppender(logAppender);
 
-		mcpStatelessServerTransport.service(request, response);
+		try {
+			var mcpServer = McpServer.sync(mcpStatelessServerTransport)
+				.serverInfo("test-server", "1.0.0")
+				.capabilities(ServerCapabilities.builder().build())
+				.build();
 
-		assertThat(response.getStatus()).isEqualTo(202);
-		assertThat(response.getContentAsByteArray()).isEmpty();
+			try (var mcpClient = clientBuilder.build()) {
+				mcpClient.initialize(); // automatically sends notifications/initialized
+			}
+			finally {
+				mcpServer.close();
+			}
+		}
+		finally {
+			handlerLogger.detachAppender(logAppender);
+			logAppender.stop();
+		}
 
-		mcpServer.close();
+		assertThat(logAppender.list).noneMatch(event -> event.getLevel() == Level.WARN
+				&& (event.getFormattedMessage().contains(McpSchema.METHOD_NOTIFICATION_INITIALIZED)
+						|| event.getFormattedMessage().contains("Missing handler for request type")));
 	}
 
 	@Test
-	void testRootsListChangedNotificationCallReturnsAccepted() throws Exception {
-		var mcpServer = McpServer.sync(mcpStatelessServerTransport)
-			.serverInfo("test-server", "1.0.0")
-			.capabilities(ServerCapabilities.builder().build())
-			.build();
-
-		McpSchema.JSONRPCNotification notification = new McpSchema.JSONRPCNotification(McpSchema.JSONRPC_VERSION,
-				McpSchema.METHOD_NOTIFICATION_ROOTS_LIST_CHANGED, null);
-
-		MockHttpServletRequest request = new MockHttpServletRequest("POST", CUSTOM_MESSAGE_ENDPOINT);
-		MockHttpServletResponse response = new MockHttpServletResponse();
+	void testRootsListChangedNotificationDoesNotLogWarn() {
+		Logger handlerLogger = (Logger) LoggerFactory.getLogger(DefaultMcpStatelessServerHandler.class);
+		ListAppender<ILoggingEvent> logAppender = new ListAppender<>();
+		logAppender.start();
+		handlerLogger.addAppender(logAppender);
 
-		byte[] content = JSON_MAPPER.writeValueAsBytes(notification);
-		request.setContent(content);
-		request.addHeader("Content-Type", "application/json");
-		request.addHeader("Content-Length", Integer.toString(content.length));
-		request.addHeader("Accept", APPLICATION_JSON + ", " + TEXT_EVENT_STREAM);
-		request.addHeader("Cache-Control", "no-cache");
-		request.addHeader(HttpHeaders.PROTOCOL_VERSION, ProtocolVersions.MCP_2025_03_26);
-
-		mcpStatelessServerTransport.service(request, response);
+		try {
+			var mcpServer = McpServer.sync(mcpStatelessServerTransport)
+				.serverInfo("test-server", "1.0.0")
+				.capabilities(ServerCapabilities.builder().build())
+				.build();
 
-		assertThat(response.getStatus()).isEqualTo(202);
-		assertThat(response.getContentAsByteArray()).isEmpty();
+			try (var mcpClient = clientBuilder.build()) {
+				mcpClient.initialize();
+				mcpClient.rootsListChangedNotification();
+			}
+			finally {
+				mcpServer.close();
+			}
+		}
+		finally {
+			handlerLogger.detachAppender(logAppender);
+			logAppender.stop();
+		}
 
-		mcpServer.close();
+		assertThat(logAppender.list).noneMatch(event -> event.getLevel() == Level.WARN
+				&& (event.getFormattedMessage().contains(McpSchema.METHOD_NOTIFICATION_ROOTS_LIST_CHANGED)
+						|| event.getFormattedMessage().contains("Missing handler for request type")));
 	}
 
 	private double evaluateExpression(String expression) {