chore(settings, shell, preferences-model): add typecheck for test files (#7571)

Author: Anemy

packages/compass-preferences-model/package.json

@@ -47,7 +47,7 @@
     "test": "mocha",
     "test-ci": "npm run test",
     "reformat": "npm run eslint . -- --fix && npm run prettier -- --write .",
-    "typecheck": "echo \"TODO(COMPASS-9897): typecheck is failing in test files\" && tsc -p tsconfig-build.json --noEmit"
+    "typecheck": "tsc -p tsconfig.json --noEmit"
   },
   "dependencies": {
     "@mongodb-js/compass-app-registry": "^9.4.28",

packages/compass-preferences-model/src/renderer-ipc.spec.ts

@@ -1,10 +1,11 @@
 import { makePreferencesIpc } from './renderer-ipc';
 import { EventEmitter } from 'events';
 import { expect } from 'chai';
+import type { UserPreferences } from './preferences-schema';
 
 describe('Renderer IPC', function () {
   const ipcImpl = {
-    'compass:save-preferences'(attributes) {
+    'compass:save-preferences'(attributes: Partial<UserPreferences>) {
       return { savePreferences: 1, attributes };
     },
     'compass:get-preferences'() {
@@ -19,7 +20,7 @@ describe('Renderer IPC', function () {
   };
   const ipcMock = Object.assign(new EventEmitter(), {
     invoke(method: string, ...args: any[]) {
-      return Promise.resolve(ipcImpl[method](...args));
+      return Promise.resolve((ipcImpl as any)[method](...args));
     },
   });
   const preferencesIpc = makePreferencesIpc(ipcMock as any);

packages/compass-settings/package.json

@@ -33,7 +33,7 @@
     "bootstrap": "npm run compile",
     "compile": "tsc -p tsconfig-build.json",
     "start": "npm run webpack serve -- --mode development",
-    "typecheck": "echo \"TODO(COMPASS-9897): typecheck is failing in test files\" && tsc -p tsconfig-build.json --noEmit",
+    "typecheck": "tsc -p tsconfig.json --noEmit",
     "eslint": "eslint-compass",
     "prettier": "prettier-compass",
     "lint": "npm run eslint . && npm run prettier -- --check .",

packages/compass-settings/src/components/modal.spec.tsx

@@ -8,7 +8,7 @@ import {
   cleanup,
   userEvent,
 } from '@mongodb-js/testing-library-compass';
-import { spy, stub } from 'sinon';
+import { spy } from 'sinon';
 import type { SinonSpy } from 'sinon';
 import { expect } from 'chai';
 import { Provider } from 'react-redux';
@@ -18,7 +18,6 @@ import { SettingsModal } from './modal';
 
 describe('SettingsModal', function () {
   let onCloseSpy: SinonSpy;
-  let fetchSettingsSpy: SinonSpy;
   let onSaveSpy: SinonSpy;
   let onSelectTabSpy: SinonSpy;
   let renderSettingsModal: (
@@ -27,7 +26,6 @@ describe('SettingsModal', function () {
 
   beforeEach(function () {
     onCloseSpy = spy();
-    fetchSettingsSpy = stub().resolves();
     onSaveSpy = spy();
     onSelectTabSpy = spy();
 
@@ -40,11 +38,11 @@ describe('SettingsModal', function () {
           <SettingsModal
             isOpen={false}
             onClose={onCloseSpy}
-            fetchSettings={fetchSettingsSpy}
             onSave={onSaveSpy}
             onSelectTab={onSelectTabSpy}
-            loadingState="ready"
+            selectedTab={undefined}
             hasChangedSettings={false}
+            isOIDCEnabled={false}
             {...props}
           />
         </Provider>
@@ -59,7 +57,6 @@ describe('SettingsModal', function () {
   it('renders nothing until it is open and loaded', function () {
     renderSettingsModal({ isOpen: false });
 
-    expect(fetchSettingsSpy.called).to.be.false;
     const container = screen.queryByTestId('settings-modal');
     expect(container).to.not.exist;
   });

packages/compass-settings/src/components/settings/general.spec.tsx

@@ -36,12 +36,13 @@ describe('GeneralSettings', function () {
     cleanup();
   });
 
-  [
+  const settings: (keyof ReturnType<typeof getSettings>)[] = [
     'readOnly',
     'enableShell',
     'protectConnectionStrings',
     'showKerberosPasswordField',
-  ].forEach((option) => {
+  ];
+  settings.forEach((option) => {
     it(`renders ${option}`, function () {
       expect(within(container).getByTestId(option)).to.exist;
     });

packages/compass-settings/src/components/settings/oidc-settings.spec.tsx

@@ -36,7 +36,11 @@ describe('OIDCSettings', function () {
     cleanup();
   });
 
-  ['showOIDCDeviceAuthFlow', 'persistOIDCTokens'].forEach((option) => {
+  const settings: (keyof ReturnType<typeof getSettings>)[] = [
+    'showOIDCDeviceAuthFlow',
+    'persistOIDCTokens',
+  ];
+  settings.forEach((option) => {
     it(`renders ${option}`, function () {
       expect(within(container).getByTestId(option)).to.exist;
     });

packages/compass-settings/src/components/settings/privacy.spec.tsx

@@ -13,7 +13,7 @@ import configureStore from '../../../test/configure-store';
 import { fetchSettings } from '../../stores/settings';
 
 function renderPrivacySettings(
-  store,
+  store: ReturnType<typeof configureStore>,
   props: Partial<React.ComponentProps<typeof PrivacySettings>> = {}
 ) {
   const component = () => (
@@ -47,12 +47,13 @@ describe('PrivacySettings', function () {
       container = renderPrivacySettings(store);
     });
 
-    [
+    const settings: (keyof ReturnType<typeof getSettings>)[] = [
       'autoUpdates',
       'enableMaps',
       'trackUsageStatistics',
       'enableFeedbackPanel',
-    ].forEach((option) => {
+    ];
+    settings.forEach((option) => {
       it(`renders ${option}`, function () {
         expect(within(container).getByTestId(option)).to.exist;
       });

packages/compass-shell/package.json

@@ -33,7 +33,7 @@
     "bootstrap": "npm run compile",
     "compile": "tsc -p tsconfig-build.json",
     "start": "npm run webpack serve -- --mode development",
-    "typecheck": "echo \"TODO(COMPASS-9897): typecheck is failing in test files\" && tsc -p tsconfig-build.json --noEmit",
+    "typecheck": "tsc -p tsconfig.json --noEmit",
     "eslint": "eslint-compass",
     "prettier": "prettier-compass",
     "lint": "npm run eslint . && npm run prettier -- --check .",

packages/compass-shell/src/components/shell-header/shell-header.spec.tsx

@@ -4,10 +4,13 @@ import { expect } from 'chai';
 
 import { ShellHeader } from './shell-header';
 
-function renderShellHeader(props) {
+function renderShellHeader(
+  props: Partial<React.ComponentProps<typeof ShellHeader>> = {}
+) {
   return render(
     <ShellHeader
       isExpanded={false}
+      darkMode
       isOperationInProgress={false}
       onShellToggleClicked={() => {}}
       showInfoModal={() => {}}

packages/compass-shell/src/modules/history-storage.spec.ts

@@ -62,7 +62,8 @@ describe('HistoryStorage', function () {
       try {
         await fs.access(historyFilePath);
         expect.fail('Expected file to not exist');
-      } catch (e) {
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      } catch (e: any) {
         expect(e.code).to.equal('ENOENT');
       }
       expect(await historyStorage.load()).to.deep.equal([]);