refactor(errors): ensure all errors use Nan::Error

Author: mbroadst

src/unix/kerberos_unix.cc

@@ -32,7 +32,7 @@ NAN_METHOD(KerberosClient::Step) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -60,7 +60,7 @@ NAN_METHOD(KerberosClient::UnwrapData) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -87,7 +87,7 @@ NAN_METHOD(KerberosClient::WrapData) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -118,7 +118,7 @@ NAN_METHOD(KerberosServer::Step) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -165,7 +165,7 @@ NAN_METHOD(InitializeClient) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -194,7 +194,7 @@ NAN_METHOD(InitializeServer) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -217,7 +217,7 @@ NAN_METHOD(PrincipalDetails) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -249,7 +249,7 @@ NAN_METHOD(CheckPassword) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
             } else {
                 v8::Local<v8::Value> argv[] = {Nan::Null(), Nan::Null()};

src/win32/kerberos_win32.cc

@@ -48,7 +48,7 @@ NAN_METHOD(KerberosClient::Step) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -76,7 +76,7 @@ NAN_METHOD(KerberosClient::UnwrapData) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -103,7 +103,7 @@ NAN_METHOD(KerberosClient::WrapData) {
             Nan::HandleScope scope;
 
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }
@@ -161,7 +161,7 @@ NAN_METHOD(InitializeClient) {
         return onFinished([=](KerberosWorker* worker) {
             Nan::HandleScope scope;
             if (result->code == AUTH_GSS_ERROR) {
-                v8::Local<v8::Value> argv[] = {Nan::New(result->message).ToLocalChecked(), Nan::Null()};
+                v8::Local<v8::Value> argv[] = {Nan::Error(result->message), Nan::Null()};
                 worker->Call(2, argv);
                 return;
             }