chore: throw on nodb

Author: gagik

scripts/generateArguments.ts

@@ -11,7 +11,7 @@
 import { readFileSync, writeFileSync } from "fs";
 import { join, dirname } from "path";
 import { fileURLToPath } from "url";
-import { UserConfigSchemaWithCliOptions, configRegistry } from "../src/common/config/userConfig.js";
+import { UserConfigSchema, configRegistry } from "../src/common/config/userConfig.js";
 import { execSync } from "child_process";
 import type { z as z4 } from "zod/v4";
 
@@ -108,7 +108,7 @@ function extractZodDescriptions(): Record<string, ConfigMetadata> {
     const result: Record<string, ConfigMetadata> = {};
 
     // Get the shape of the Zod schema
-    const shape = UserConfigSchemaWithCliOptions.shape;
+    const shape = UserConfigSchema.shape;
 
     for (const [key, fieldSchema] of Object.entries(shape)) {
         const schema = fieldSchema;

src/common/config/createUserConfig.ts

@@ -22,6 +22,14 @@ export function createUserConfig({ args }: { args: string[] }): {
         return { error: parseError, warnings, parsed: undefined };
     }
 
+    if (parsed.nodb) {
+        return {
+            error: "Error: The --nodb argument is not supported in the MCP Server. Please remove it from your configuration.",
+            warnings,
+            parsed: undefined,
+        };
+    }
+
     // If we have a connectionSpecifier, which can only appear as the positional
     // argument, then that has to be used on priority to construct the
     // connection string. In this case, if there is a connection string provided
@@ -145,12 +153,6 @@ function getWarnings(config: Partial<UserConfig>, cliArguments: string[]): strin
         );
     }
 
-    if (config.nodb) {
-        warnings.push(
-            "Warning: The nodb option is deprecated and will be removed in a future version. Please remove it from your configuration."
-        );
-    }
-
     const searchEnabled = config.previewFeatures?.includes("search");
     const embeddingsProviderConfigured = !!config.voyageApiKey;
     if (searchEnabled && !embeddingsProviderConfigured) {

src/common/config/userConfig.ts

@@ -10,11 +10,11 @@ import {
     parseBoolean,
 } from "./configUtils.js";
 import { previewFeatureValues, similarityValues } from "../schemas.js";
-import { CliOptionsSchema } from "@mongosh/arg-parser/arg-parser";
+import { CliOptionsSchema as MongoshCliOptionsSchema } from "@mongosh/arg-parser/arg-parser";
 
 export const configRegistry = z4.registry<ConfigFieldMeta>();
 
-export const UserConfigSchema = z4.object({
+const ServerConfigSchema = z4.object({
     apiBaseUrl: z4
         .string()
         .default("https://cloud.mongodb.com/")
@@ -218,13 +218,11 @@ export const UserConfigSchema = z4.object({
         .register(configRegistry, { overrideBehavior: "not-allowed" }),
 });
 
-export const UserConfigSchemaWithCliOptions = z4.object({
-    ...CliOptionsSchema.shape,
-    ...UserConfigSchema.shape,
+export const UserConfigSchema = z4.object({
+    ...MongoshCliOptionsSchema.shape,
+    ...ServerConfigSchema.shape,
 });
 
-export type UserConfig = z4.infer<typeof UserConfigSchemaWithCliOptions>;
+export type UserConfig = z4.infer<typeof UserConfigSchema>;
 
-export const ALL_CONFIG_KEYS: (keyof UserConfig)[] = Object.keys(
-    UserConfigSchemaWithCliOptions.shape
-) as (keyof UserConfig)[];
+export const ALL_CONFIG_KEYS: (keyof UserConfig)[] = Object.keys(UserConfigSchema.shape) as (keyof UserConfig)[];

tests/e2e/cli.test.ts

@@ -57,11 +57,6 @@ describe("CLI entrypoint", () => {
                     warning:
                         "Warning: The --connectionString argument is deprecated. Prefer using the MDB_MCP_CONNECTION_STRING environment variable or the first positional argument for the connection string.",
                 },
-                {
-                    cliArg: "--nodb",
-                    warning:
-                        "Warning: The nodb option is deprecated and will be removed in a future version. Please remove it from your configuration.",
-                },
             ] as const;
 
             for (const { cliArg, value, warning } of testCases) {
@@ -86,6 +81,11 @@ describe("CLI entrypoint", () => {
                     args: ["--wakanda", "forever"],
                     expectedError: "Error: Invalid command line argument '--wakanda'.",
                 },
+                {
+                    description: "should show an error when nodb is used",
+                    args: ["--nodb"],
+                    expectedError: "Error: Invalid command line argument '--nodb'.",
+                },
                 {
                     description: "should show a suggestion when is a simple typo",
                     args: ["--readonli", ""],