changed the SetPid function to return the value and remove the side effect.

Author: craiggwilson

Bson/ObjectModel/ObjectId.cs

@@ -55,7 +55,7 @@ static ObjectId()
 
             try
             {
-                SetPidToCurrentProcessId();
+                __staticPid = GetCurrentProcessId();
             }
             catch (SecurityException)
             {
@@ -362,6 +362,17 @@ public static void Unpack(byte[] bytes, out int timestamp, out int machine, out
         }
 
         // private static methods
+        /// <summary>
+        /// Gets the current process id.  This method exists because of how CAS operates on the call stack, checking
+        /// for permissions before executing the method.  Hence, if we inlined this call, the calling method would not execute
+        /// before throwing an exception requiring the try/catch at an even higher level that we don't necessarily control.
+        /// </summary>
+        [MethodImpl(MethodImplOptions.NoInlining)]
+        private static short GetCurrentProcessId()
+        {
+            return (short)Process.GetCurrentProcess().Id;
+        }
+
         private static int GetMachineHash()
         {
             var hostName = Environment.MachineName; // use instead of Dns.HostName so it will work offline
@@ -375,17 +386,6 @@ private static int GetTimestampFromDateTime(DateTime timestamp)
             return (int)Math.Floor((BsonUtils.ToUniversalTime(timestamp) - BsonConstants.UnixEpoch).TotalSeconds);
         }
 
-        /// <summary>
-        /// Sets the pid to current process id.  This method exists because of how CAS operates on the call stack, checking
-        /// for permissions before executing the method.  Hence, if we inlined this call, the calling method would not execute
-        /// before throwing an exception requiring the try/catch at an even higher level that we don't necessarily control.
-        /// </summary>
-        [MethodImpl(MethodImplOptions.NoInlining)]
-        private static void SetPidToCurrentProcessId()
-        {
-            __staticPid = (short)Process.GetCurrentProcess().Id;
-        }
-
         // public methods
         /// <summary>
         /// Compares this ObjectId to another ObjectId.