PHPLIB-1320: Support "comment" command option in Collection::createIndex() (#1263)

Adds test coverage for "comment" and "commitQuorum" options. This changes the test to require a 4.4+ non-standalone, which is acceptable given our CI matrix.

Author: jmikola

src/Collection.php

@@ -322,11 +322,11 @@ public function countDocuments($filter = [], array $options = [])
      */
     public function createIndex($key, array $options = [])
     {
-        $commandOptionKeys = ['commitQuorum' => 1, 'maxTimeMS' => 1, 'session' => 1, 'writeConcern' => 1];
-        $indexOptions = array_diff_key($options, $commandOptionKeys);
-        $commandOptions = array_intersect_key($options, $commandOptionKeys);
+        $operationOptionKeys = ['comment' => 1, 'commitQuorum' => 1, 'maxTimeMS' => 1, 'session' => 1, 'writeConcern' => 1];
+        $indexOptions = array_diff_key($options, $operationOptionKeys);
+        $operationOptions = array_intersect_key($options, $operationOptionKeys);
 
-        return current($this->createIndexes([['key' => $key] + $indexOptions], $commandOptions));
+        return current($this->createIndexes([['key' => $key] + $indexOptions], $operationOptions));
     }
 
     /**

tests/Collection/CollectionFunctionalTest.php

@@ -132,11 +132,19 @@ public function testAggregateWithinTransaction(): void
 
     public function testCreateIndexSplitsCommandOptions(): void
     {
+        $this->skipIfServerVersion('<', '4.4', 'commitQuorum and comment options are not supported');
+
+        if ($this->isStandalone()) {
+            $this->markTestSkipped('commitQuorum is not supported');
+        }
+
         (new CommandObserver())->observe(
             function (): void {
                 $this->collection->createIndex(
                     ['x' => 1],
                     [
+                        'comment' => 'foo',
+                        'commitQuorum' => 'majority',
                         'maxTimeMS' => 10000,
                         'session' => $this->manager->startSession(),
                         'sparse' => true,
@@ -147,6 +155,8 @@ function (): void {
             },
             function (array $event): void {
                 $command = $event['started']->getCommand();
+                $this->assertObjectHasAttribute('comment', $command);
+                $this->assertObjectHasAttribute('commitQuorum', $command);
                 $this->assertObjectHasAttribute('lsid', $command);
                 $this->assertObjectHasAttribute('maxTimeMS', $command);
                 $this->assertObjectHasAttribute('writeConcern', $command);