Remove tests for pre-4.2 servers

Author: jmikola

tests/Collection/BuilderCollectionFunctionalTest.php

@@ -231,8 +231,6 @@ public function testUpdateOne(): void
 
     public function testUpdateWithPipeline(): void
     {
-        $this->skipIfServerVersion('<', '4.2.0', 'Pipeline-style updates are not supported');
-
         $result = $this->collection->updateOne(
             Query::query(x: Query::lt(2)),
             new Pipeline(
@@ -259,8 +257,6 @@ public function testUpdateMany(): void
 
     public function testUpdateManyWithPipeline(): void
     {
-        $this->skipIfServerVersion('<', '4.2.0', 'Pipeline-style updates are not supported');
-
         $result = $this->collection->updateMany(
             Query::query(x: Query::gt(1)),
             new Pipeline(

tests/FunctionalTestCase.php

@@ -469,10 +469,6 @@ protected function skipIfCausalConsistencyIsNotSupported(): void
 
     protected function skipIfClientSideEncryptionIsNotSupported(): void
     {
-        if (version_compare($this->getFeatureCompatibilityVersion(), '4.2', '<')) {
-            $this->markTestSkipped('Client Side Encryption only supported on FCV 4.2 or higher');
-        }
-
         if (static::getModuleInfo('libmongocrypt') === 'disabled') {
             $this->markTestSkipped('Client Side Encryption is not enabled in the MongoDB extension');
         }

tests/Operation/BulkWriteFunctionalTest.php

@@ -198,10 +198,6 @@ function (array $event) use ($expectedReplacement): void {
     #[DataProvider('provideUpdatePipelines')]
     public function testUpdateDocuments($update, $expectedUpdate): void
     {
-        if (is_array($expectedUpdate)) {
-            $this->skipIfServerVersion('<', '4.2.0', 'Pipeline-style updates are not supported');
-        }
-
         (new CommandObserver())->observe(
             function () use ($update): void {
                 $operation = new BulkWrite(
@@ -423,8 +419,6 @@ function (array $event): void {
 
     public function testBulkWriteWithPipelineUpdates(): void
     {
-        $this->skipIfServerVersion('<', '4.2.0', 'Pipeline-style updates are not supported');
-
         $this->createFixtures(4);
 
         $ops = [

tests/Operation/ExplainFunctionalTest.php

@@ -322,8 +322,6 @@ public function testAggregate(): void
     #[DataProvider('provideVerbosityInformation')]
     public function testAggregateOptimizedToQuery($verbosity, $executionStatsExpected, $allPlansExecutionExpected): void
     {
-        $this->skipIfServerVersion('<', '4.2.0', 'MongoDB < 4.2 does not optimize simple aggregation pipelines');
-
         $this->createFixtures(3);
 
         $pipeline = [['$match' => ['_id' => ['$ne' => 2]]]];

tests/Operation/FindAndModifyFunctionalTest.php

@@ -126,22 +126,6 @@ function (array $event): void {
         );
     }
 
-    public function testHintOptionUnsupportedClientSideError(): void
-    {
-        $this->skipIfServerVersion('>=', '4.2.0', 'server reports error for unsupported findAndModify options');
-
-        $operation = new FindAndModify(
-            $this->getDatabaseName(),
-            $this->getCollectionName(),
-            ['remove' => true, 'hint' => '_id_'],
-        );
-
-        $this->expectException(UnsupportedException::class);
-        $this->expectExceptionMessage('Hint is not supported by the server executing this operation');
-
-        $operation->execute($this->getPrimaryServer());
-    }
-
     public function testHintOptionAndUnacknowledgedWriteConcernUnsupportedClientSideError(): void
     {
         $this->skipIfServerVersion('>=', '4.4.0', 'hint is supported');

tests/Operation/UpdateFunctionalTest.php

@@ -54,10 +54,6 @@ function (array $event) use ($expectedFilter): void {
     #[DataProvider('provideReplacementDocumentLikePipeline')]
     public function testUpdateDocuments($update, $expectedUpdate): void
     {
-        if (is_array($expectedUpdate)) {
-            $this->skipIfServerVersion('<', '4.2.0', 'Pipeline-style updates are not supported');
-        }
-
         (new CommandObserver())->observe(
             function () use ($update): void {
                 $operation = new Update(
@@ -148,24 +144,6 @@ function (array $event): void {
         );
     }
 
-    public function testHintOptionAndUnacknowledgedWriteConcernUnsupportedClientSideError(): void
-    {
-        $this->skipIfServerVersion('>=', '4.2.0', 'hint is supported');
-
-        $operation = new Update(
-            $this->getDatabaseName(),
-            $this->getCollectionName(),
-            ['_id' => 1],
-            ['$inc' => ['x' => 1]],
-            ['hint' => '_id_', 'writeConcern' => new WriteConcern(0)],
-        );
-
-        $this->expectException(UnsupportedException::class);
-        $this->expectExceptionMessage('Hint is not supported by the server executing this operation');
-
-        $operation->execute($this->getPrimaryServer());
-    }
-
     public function testUpdateOne(): void
     {
         $this->createFixtures(3);

tests/SpecTests/PrimaryStepDownSpecTest.php

@@ -72,43 +72,6 @@ public function testNotPrimaryKeepsConnectionPool(): void
         $this->assertSame($totalConnectionsCreated, $this->getTotalConnectionsCreated());
     }
 
-    /** @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#not-primary-reset-connection-pool */
-    public function testNotPrimaryResetConnectionPool(): void
-    {
-        $runOn = [(object) ['minServerVersion' => '4.0.0', 'maxServerVersion' => '4.0.999', 'topology' => [self::TOPOLOGY_REPLICASET]]];
-        $this->checkServerRequirements($runOn);
-
-        // Set a fail point
-        $this->configureFailPoint([
-            'configureFailPoint' => 'failCommand',
-            'mode' => ['times' => 1],
-            'data' => [
-                'failCommands' => ['insert'],
-                'errorCode' => self::NOT_PRIMARY,
-            ],
-        ]);
-
-        $totalConnectionsCreated = $this->getTotalConnectionsCreated();
-
-        // Execute an insert into the test collection of a {test: 1} document.
-        try {
-            $this->insertDocuments(1);
-        } catch (BulkWriteException $e) {
-            // Verify that the insert failed with an operation failure with 10107 code.
-            $this->assertSame(self::NOT_PRIMARY, $e->getCode());
-        }
-
-        /* Verify that the connection pool has been cleared and that a new
-         * connection has been created. Use ">=" to allow for the possibility
-         * that the server created additional connections unrelated to this
-         * test. */
-        $this->assertGreaterThanOrEqual($totalConnectionsCreated + 1, $this->getTotalConnectionsCreated());
-
-        // Execute an insert into the test collection of a {test: 1} document and verify that it succeeds.
-        $result = $this->insertDocuments(1);
-        $this->assertSame(1, $result->getInsertedCount());
-    }
-
     /** @see https://github.com/mongodb/specifications/tree/master/source/connections-survive-step-down/tests#shutdown-in-progress-reset-connection-pool */
     public function testShutdownResetConnectionPool(): void
     {

tests/UnifiedSpecTests/UnifiedTestRunner.php

@@ -337,12 +337,6 @@ private function isAuthenticated(): bool
      */
     private function isClientSideEncryptionSupported(): bool
     {
-        /* CSFLE technically requires FCV 4.2+ but this is sufficient since we
-         * do not test on mixed-version clusters. */
-        if (version_compare($this->getServerVersion(), '4.2', '<')) {
-            return false;
-        }
-
         if (FunctionalTestCase::getModuleInfo('libmongocrypt') === 'disabled') {
             return false;
         }