PHPLIB-810: Always use count command for estimatedDocumentCount (#926)

Spec tests synced with mongodb/specifications@021cbc8

Co-authored-by: Jeremy Mikola <jmikola@gmail.com>

Author: aleksandr-rudo

src/Operation/EstimatedDocumentCount.php

@@ -17,7 +17,6 @@
 
 namespace MongoDB\Operation;
 
-use MongoDB\Driver\Exception\CommandException;
 use MongoDB\Driver\Exception\RuntimeException as DriverRuntimeException;
 use MongoDB\Driver\ReadConcern;
 use MongoDB\Driver\ReadPreference;
@@ -29,7 +28,6 @@
 
 use function array_intersect_key;
 use function is_integer;
-use function MongoDB\server_supports_feature;
 
 /**
  * Operation for obtaining an estimated count of documents in a collection
@@ -111,25 +109,7 @@ public function __construct($databaseName, $collectionName, array $options = [])
      */
     public function execute(Server $server)
     {
-        $command = $this->createCommand($server);
-
-        if ($command instanceof Aggregate) {
-            try {
-                $cursor = $command->execute($server);
-            } catch (CommandException $e) {
-                if ($e->getCode() == self::$errorCodeCollectionNotFound) {
-                    return 0;
-                }
-
-                throw $e;
-            }
-
-            $cursor->rewind();
-
-            return $cursor->current()->n;
-        }
-
-        return $command->execute($server);
+        return $this->createCount()->execute($server);
     }
 
     /**
@@ -141,28 +121,7 @@ public function execute(Server $server)
      */
     public function getCommandDocument(Server $server)
     {
-        return $this->createCommand($server)->getCommandDocument($server);
-    }
-
-    private function createAggregate(): Aggregate
-    {
-        return new Aggregate(
-            $this->databaseName,
-            $this->collectionName,
-            [
-                ['$collStats' => ['count' => (object) []]],
-                ['$group' => ['_id' => 1, 'n' => ['$sum' => '$count']]],
-            ],
-            $this->options
-        );
-    }
-
-    /** @return Aggregate|Count */
-    private function createCommand(Server $server)
-    {
-        return server_supports_feature($server, self::$wireVersionForCollStats)
-            ? $this->createAggregate()
-            : $this->createCount();
+        return $this->createCount()->getCommandDocument($server);
     }
 
     private function createCount(): Count

tests/SpecTests/atlas_data_lake/estimatedDocumentCount.json

@@ -15,24 +15,9 @@
         {
           "command_started_event": {
             "command": {
-              "aggregate": "driverdata",
-              "pipeline": [
-                {
-                  "$collStats": {
-                    "count": {}
-                  }
-                },
-                {
-                  "$group": {
-                    "_id": 1,
-                    "n": {
-                      "$sum": "$count"
-                    }
-                  }
-                }
-              ]
+              "count": "driverdata"
             },
-            "command_name": "aggregate",
+            "command_name": "count",
             "database_name": "test"
           }
         }