Merge pull request #36 from stronk7/integration_test

Integration test & PHPCompatibility bump to develop#2fb82334

Author: andrewnicols

.github/workflows/phpcs.yml

@@ -22,7 +22,7 @@ jobs:
         with:
           php-version: ${{ matrix.php }}
           extensions: ${{ matrix.extensions }}
-          ini-values: pcov.directory=moodle
+          ini-values: pcov.directory=moodle, error_reporting=-1, display_errors=On
           coverage: pcov
           tools: composer
 
@@ -46,3 +46,17 @@ jobs:
 
       - name: Test coverage
         run: ./vendor/bin/phpunit-coverage-check -t 80 clover.xml
+
+      - name: Integration tests
+        if: ${{ always() }}
+        run: |
+          # There is one failure (exit with error)
+          vendor/bin/phpcs --standard=moodle moodle/Tests/fixtures/integration_test_ci.php | tee output.txt || [[ $? = 1 ]]
+          grep -q  "PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY" output.txt
+
+          # The failure is fixed (exit with error)
+          vendor/bin/phpcbf --standard=moodle moodle/Tests/fixtures/integration_test_ci.php | tee output.txt || [[ $? = 1 ]]
+          grep -q "A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE" output.txt
+
+          # So, there isn't any failure any more (exit without error)
+          vendor/bin/phpcs --standard=moodle moodle/Tests/fixtures/integration_test_ci.php | tee output.txt && [[ $? = 0 ]]

composer.json

@@ -16,8 +16,8 @@
     ],
     "require": {
         "dealerdirect/phpcodesniffer-composer-installer": "^0.7.2",
-        "squizlabs/php_codesniffer": "^3.6",
-        "phpcompatibility/php-compatibility": "^9.3"
+        "squizlabs/php_codesniffer": "^3.7.1",
+        "phpcompatibility/php-compatibility": "dev-develop#2fb82334"
     },
     "config": {
         "allow-plugins": {

moodle/Tests/fixtures/integration_test_ci.php

@@ -0,0 +1,4 @@
+<?php
+// phpcs:disable moodle.Files
+defined('MOODLE_INTERNAL') || die(); // Make this always the 1st line in all CS fixtures.
+$arr ['wrong'] = $value;

moodle/ruleset.xml

@@ -43,6 +43,8 @@
 
     <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
 
+    <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
+
     <rule ref="Squiz.Commenting.DocCommentAlignment"/>
     <rule ref="Squiz.Commenting.EmptyCatchComment"/>