[Bug]: When an add-on hits a second level approval queue, it creates as many entries as the number of DSA jobs the reviewer resolved

[abhn]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Basically the title, suppose

• There's an add-on which has 5 DSA reports
• Reviewer rejects it in a way that it is caught in the second level approval queue
• The second level approver now needs to do their work 5 times as 5 entries are created for this action

What did you expect to happen?

• Only one entry per reviewer action should be created for second level approval
• Multiple entries shouldn't cause confusion on which "proceed to action" would actually result in the reviewer action going through

┆Issue is synchronized with this Jira Task

[diox]

How often is this happening ? I imagine this is because escalated reports are creating new jobs, but @eviljeff would know more.

[eviljeff]

The second level approval queue is just a view of ContentDecision instances without an action_date. So if resolving 5 jobs creates 5 decisions, that are all held, so don't get an action_date, then 5 are shown in the queue.

Cinder originated decisions don't have this problem - one job is processed at once, leading to one decision. Reviewer Tools does because we allow multiple jobs to be resolved at once (there are multiple jobs only because Cinder jobs don't merge when they're moved to a different queue - i.e. escalations).

I would think the fix for this is to make the 2nd level approval queue more complicated - to show addons rather than decisions, and then to bundle all the decisions together. (Though now we have edge cases- e.g. what if the Reviewer wants to proceed with some decisions and requeue others)

[abhn]

How often is this happening ?

Fairly consistently. I regularly see it happen with multiple (same add-on) entries in the second level approval queue, but the real pain is when it is 10+ jobs and then I have to do dozens of clicks and am not certain what "proceed with action" actually rejects the add-on.

[abhn]

what if the Reviewer wants to proceed with some decisions and requeue others

I'd think of those as separate reviewer decisions/actions (not jobs). Those should anyway create separate entries in the second level approval queue.

I always thought of second level approval as second level approval of the reviewer action, and not the job they're resolving.