Fix (?) registration bug and re-enable renameIDs

Author: sealexan

src/main/kotlin/ch/uzh/ifi/access/config/CacheConfig.kt

@@ -38,6 +38,6 @@ class CacheConfig {
 class CacheInitListener(val cacheInitService: CacheInitService) : ApplicationListener<ApplicationReadyEvent> {
     override fun onApplicationEvent(event: ApplicationReadyEvent) {
         cacheInitService.initCache()
-        //courseService.renameIDs()
+        cacheInitService.renameIDs()
     }
 }

src/main/kotlin/ch/uzh/ifi/access/service/CourseService.kt

@@ -329,8 +329,12 @@ class CourseService(
         val newUsersSet = registrationIDs.toSet()
         val existingUsersSet = existingUsers.toSet()
 
+        logger.debug { "existingUsersSet: $existingUsers" }
+        logger.debug { "newUsersSet: $newUsersSet" }
         val removedUsers = existingUsersSet.minus(newUsersSet).toList()
         val addedUsers = newUsersSet.minus(existingUsersSet).toList()
+        logger.debug { "removedUsers: $removedUsers" }
+        logger.debug { "addedUsers: $addedUsers" }
 
         when (role) {
             Role.SUPERVISOR -> course.supervisors = newUsersSet.toMutableSet()

src/main/kotlin/ch/uzh/ifi/access/service/RoleService.kt

@@ -213,6 +213,10 @@ class RoleService(
     fun initializeUserRoles(username: String) {
         try {
             semaphore.acquire()
+            // evict the username to ensure we get a UserRepresentation and not null
+            // this only happens on first login anyway, and should not be necessary,
+            // but if someone deletes a user from Keycloak manually, then the caching is broken even after a reboot
+            cacheManager.getCache("RoleService.findUserByAllCriteria")?.evict(username);
             val user = proxy.findUserByAllCriteria(username)
             if (user == null) {
                 logger.error { "Trying to initialize roles for $username: no matching username in Keycloak" }