Skip to content

Commit 5ac5138

Browse files
committed
Switch to ReplaySubject + Observable for getter
1 parent c330adb commit 5ac5138

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/components/spinner/spinner.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class SpinnerComponent implements OnDestroy, OnInit {
4545
.subscribe(this.handleSpinnerVisibility().bind(this));
4646

4747
this.visibilitySubscription = this.spinnerVisibilityService
48-
.visibilitySubject
48+
.visibilityObservable
4949
.subscribe(this.handleSpinnerVisibility().bind(this));
5050
}
5151

src/services/spinner-visibility.service.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
*/
99

1010
import { Injectable } from '@angular/core';
11-
import { Subject } from 'rxjs/Subject';
11+
import { Observable } from 'rxjs/Observable';
12+
import { ReplaySubject } from 'rxjs/ReplaySubject';
1213

1314
@Injectable()
1415
export class SpinnerVisibilityService {
15-
private _visibilitySubject: Subject<boolean> = new Subject<boolean>();
16+
private _visibilitySubject: ReplaySubject<boolean> = new ReplaySubject<boolean>(1);
1617

17-
get visibilitySubject(): Subject<boolean> {
18-
return this._visibilitySubject;
18+
get visibilityObservable(): Observable<boolean> {
19+
return this._visibilitySubject.asObservable();
1920
}
2021
}
2122

0 commit comments

Comments
 (0)