filteredUrlPatterns should take care of query strings too when trying to match

Author: mpalourdio

src/services/pending-interceptor.service.ts

@@ -39,7 +39,7 @@ export class PendingInterceptorService implements HttpInterceptor {
     }
 
     intercept(req: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {
-        const shouldBypass = this.shouldBypass(req.url);
+        const shouldBypass = this.shouldBypass(req.urlWithParams);
 
         if (!shouldBypass) {
             this._pendingRequests++;

test/components/spinner/spinner.component.spec.ts

@@ -151,6 +151,26 @@ describe('SpinnerComponent', () => {
         }
     )));
 
+    it('should take care of query strings in filteredUrlPatterns', fakeAsync(inject(
+        [PendingInterceptorService, HttpClient, HttpTestingController],
+        (service: PendingInterceptorService, http: HttpClient, httpMock: HttpTestingController) => {
+            component.filteredUrlPatterns.push('bar');
+            fixture.detectChanges();
+
+            http.get(
+                '/api/service',
+                {
+                    'params': {
+                        'foo': 'bar'
+                    }
+                }
+            ).subscribe();
+            tick();
+            expect(component.isSpinnerVisible).toBeFalsy();
+            httpMock.expectOne('/api/service?foo=bar').flush({});
+        }
+    )));
+
     it('should correctly filter with several requests and one pattern', fakeAsync(inject(
         [PendingInterceptorService, HttpClient, HttpTestingController],
         (service: PendingInterceptorService, http: HttpClient, httpMock: HttpTestingController) => {