Skip to content

Commit b7af55f

Browse files
committed
Extract visibility duration in its own method.
1 parent ab0146e commit b7af55f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/lib/components/ng-http-loader.component.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
import { Component, Input, OnDestroy, OnInit } from '@angular/core';
1111
import { BehaviorSubject, merge, Observable, Subscription, timer } from 'rxjs';
12-
import { debounce, distinctUntilChanged, partition, switchMap } from 'rxjs/operators';
12+
import { debounce, distinctUntilChanged, partition, switchMap, tap } from 'rxjs/operators';
1313
import { PendingInterceptorService } from '../services/pending-interceptor.service';
1414
import { SpinnerVisibilityService } from '../services/spinner-visibility.service';
1515
import { Spinkit } from '../spinkits';
@@ -56,8 +56,11 @@ export class NgHttpLoaderComponent implements OnDestroy, OnInit {
5656
),
5757
this.spinnerVisibilityService.visibility$,
5858
)
59-
.pipe(distinctUntilChanged())
60-
.subscribe(h => this.handleSpinnerVisibility(h));
59+
.pipe(
60+
distinctUntilChanged(),
61+
tap(h => this.updateVisibilityDuration(h))
62+
)
63+
.subscribe(h => this._isSpinnerVisible$.next(h));
6164
}
6265

6366
ngOnInit(): void {
@@ -111,11 +114,10 @@ export class NgHttpLoaderComponent implements OnDestroy, OnInit {
111114
this.pendingInterceptorService.filteredHeaders = this.filteredHeaders;
112115
}
113116

114-
private handleSpinnerVisibility(showSpinner: boolean): void {
117+
private updateVisibilityDuration(showSpinner: boolean): void {
115118
if (showSpinner) {
116119
this.visibleUntil = Date.now() + this.minDuration;
117120
}
118-
this._isSpinnerVisible$.next(showSpinner);
119121
}
120122

121123
private getVisibilityTimer$(): Observable<number> {

0 commit comments

Comments
 (0)