Skip to content

Commit cb7eca1

Browse files
committed
Extract spinner name in const
1 parent 8f4ffaa commit cb7eca1

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/test/components/ng-http-loader.component.outlet.spec.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe('NgHttpLoaderComponentOutlet', () => {
5757
spyOnProperty(component, 'isVisible$')
5858
.and.returnValue(new BehaviorSubject(true).asObservable());
5959

60-
component.spinner = 'whatever';
60+
component.spinner = 'spinner-name';
6161
component.entryComponent = SkThreeBounceComponent;
6262
fixture.detectChanges();
6363

@@ -68,32 +68,35 @@ describe('NgHttpLoaderComponentOutlet', () => {
6868
spyOnProperty(component, 'isVisible$')
6969
.and.returnValue(new BehaviorSubject(true).asObservable());
7070

71-
component.spinner = 'whatever';
71+
const spinnerName = 'spinner-name';
72+
component.spinner = spinnerName;
7273
component.entryComponent = '';
7374
fixture.detectChanges();
7475

75-
expect(component.spinner).toBe('whatever');
76+
expect(component.spinner).toBe(spinnerName);
7677
});
7778

7879
it('should correctly check [entryComponent] with null', () => {
7980
spyOnProperty(component, 'isVisible$')
8081
.and.returnValue(new BehaviorSubject(true).asObservable());
8182

82-
component.spinner = 'whatever';
83+
const spinnerName = 'spinner-name';
84+
component.spinner = spinnerName;
8385
component.entryComponent = null;
8486
fixture.detectChanges();
8587

86-
expect(component.spinner).toBe('whatever');
88+
expect(component.spinner).toBe(spinnerName);
8789
});
8890

8991
it('should correctly check [entryComponent] with undefined', () => {
9092
spyOnProperty(component, 'isVisible$')
9193
.and.returnValue(new BehaviorSubject(true).asObservable());
9294

93-
component.spinner = 'whatever';
95+
const spinnerName = 'spinner-name';
96+
component.spinner = spinnerName;
9497
component.entryComponent = undefined;
9598
fixture.detectChanges();
9699

97-
expect(component.spinner).toBe('whatever');
100+
expect(component.spinner).toBe(spinnerName);
98101
});
99102
});

0 commit comments

Comments
 (0)