chore(ng10): Enforce strictness

Author: mpalourdio

src/lib/components/abstract.loader.directive.ts

@@ -12,5 +12,5 @@ import { Input, Directive } from '@angular/core';
 @Directive()
 export abstract class AbstractLoaderDirective {
 
-    @Input() public backgroundColor: string;
+    @Input() public backgroundColor!: string;
 }

src/lib/components/ng-http-loader.component.ts

@@ -22,11 +22,11 @@ import { Spinkit } from '../spinkits';
 export class NgHttpLoaderComponent implements OnInit {
 
     public spinkit = Spinkit;
-    public isVisible$: Observable<boolean>;
+    public isVisible$!: Observable<boolean>;
     private visibleUntil = Date.now();
 
     @Input() public backdrop = true;
-    @Input() public backgroundColor: string;
+    @Input() public backgroundColor!: string;
     @Input() public debounceDelay = 0;
     @Input() public entryComponent: any = null;
     @Input() public extraDuration = 0;
@@ -35,11 +35,17 @@ export class NgHttpLoaderComponent implements OnInit {
     @Input() public filteredUrlPatterns: string[] = [];
     @Input() public minDuration = 0;
     @Input() public opacity = '.7';
-    @Input() public spinner = Spinkit.skWave;
+    @Input() public spinner: string | null = Spinkit.skWave;
 
     constructor(private pendingRequestsInterceptor: PendingRequestsInterceptor, private spinnerVisibility: SpinnerVisibilityService) {
     }
 
+    public ngOnInit(): void {
+        this.initIsvisibleObservable();
+        this.nullifySpinnerIfEntryComponentIsDefined();
+        this.initFilters();
+    }
+
     private initIsvisibleObservable(): void {
         const [showSpinner$, hideSpinner$] = partition(this.pendingRequestsInterceptor.pendingRequestsStatus$, h => h);
 
@@ -55,12 +61,6 @@ export class NgHttpLoaderComponent implements OnInit {
         );
     }
 
-    public ngOnInit(): void {
-        this.initIsvisibleObservable();
-        this.nullifySpinnerIfEntryComponentIsDefined();
-        this.initFilters();
-    }
-
     private nullifySpinnerIfEntryComponentIsDefined(): void {
         if (this.entryComponent) {
             this.spinner = null;
@@ -74,10 +74,6 @@ export class NgHttpLoaderComponent implements OnInit {
     }
 
     private initFilteredUrlPatterns(): void {
-        if (!(this.filteredUrlPatterns instanceof Array)) {
-            throw new TypeError('`filteredUrlPatterns` must be an array.');
-        }
-
         if (!!this.filteredUrlPatterns.length) {
             this.filteredUrlPatterns.forEach(e =>
                 this.pendingRequestsInterceptor.filteredUrlPatterns.push(new RegExp(e))
@@ -86,16 +82,10 @@ export class NgHttpLoaderComponent implements OnInit {
     }
 
     private initFilteredMethods(): void {
-        if (!(this.filteredMethods instanceof Array)) {
-            throw new TypeError('`filteredMethods` must be an array.');
-        }
         this.pendingRequestsInterceptor.filteredMethods = this.filteredMethods;
     }
 
     private initFilteredHeaders(): void {
-        if (!(this.filteredHeaders instanceof Array)) {
-            throw new TypeError('`filteredHeaders` must be an array.');
-        }
         this.pendingRequestsInterceptor.filteredHeaders = this.filteredHeaders;
     }
 

src/lib/services/pending-requests-interceptor.service.ts

@@ -22,7 +22,7 @@ export class PendingRequestsInterceptor implements HttpInterceptor {
     private _filteredUrlPatterns: RegExp[] = [];
     private _filteredMethods: string[] = [];
     private _filteredHeaders: string[] = [];
-    private _forceByPass: boolean;
+    private _forceByPass = false;
 
     get pendingRequestsStatus$(): Observable<boolean> {
         return this._pendingRequestsStatus$.asObservable();

src/test/components/ng-http-loader.component.spec.ts

@@ -252,21 +252,6 @@ describe('NgHttpLoaderComponent', () => {
         expect(isVisible).toBeFalsy();
     }));
 
-    it('should throw an error if filteredUrlPatterns is not an array', () => {
-        component.filteredUrlPatterns = null;
-        expect(() => component.ngOnInit()).toThrow(new Error('`filteredUrlPatterns` must be an array.'));
-    });
-
-    it('should throw an error if filteredMethods is not an array', () => {
-        component.filteredMethods = null;
-        expect(() => component.ngOnInit()).toThrow(new Error('`filteredMethods` must be an array.'));
-    });
-
-    it('should throw an error if filteredHeaders is not an array', () => {
-        component.filteredHeaders = null;
-        expect(() => component.ngOnInit()).toThrow(new Error('`filteredHeaders` must be an array.'));
-    });
-
     it('should show the spinner even if the component is created after the HTTP request is performed', fakeAsync(() => {
         http.get('/fake').subscribe();
 

src/test/ng-http-loader.module.spec.ts

@@ -23,6 +23,7 @@ describe('NgHttpLoaderModule', () => {
 
     it('should create an instance with providers via forRoot()', () => {
         const ngHttpLoaderModuleWithProviders = NgHttpLoaderModule.forRoot();
+        // @ts-ignore
         expect(ngHttpLoaderModuleWithProviders.providers[0][0].useExisting.name).toEqual(PendingRequestsInterceptor.name);
     });
 });

tsconfig.base.json

@@ -3,21 +3,25 @@
   "compilerOptions": {
     "baseUrl": "./",
     "outDir": "./dist/out-tsc",
+    "forceConsistentCasingInFileNames": true,
+    "strict": true,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
     "sourceMap": true,
     "declaration": false,
     "downlevelIteration": true,
     "experimentalDecorators": true,
-    "module": "esnext",
     "moduleResolution": "node",
     "importHelpers": true,
     "target": "es2015",
+    "module": "es2020",
     "lib": [
       "es2018",
       "dom"
     ]
   },
   "angularCompilerOptions": {
-    "fullTemplateTypeCheck": true,
+    "strictTemplates": true,
     "strictInjectionParameters": true
   }
 }

tsconfig.lib.json

@@ -1,12 +1,11 @@
+/* To learn more about this file see: https://angular.io/config/tsconfig. */
 {
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
     "outDir": "./out-tsc/lib",
     "target": "es2015",
     "declaration": true,
     "inlineSources": true,
-    "noImplicitAny": true,
-    "noImplicitReturns": true,
     "types": [],
     "lib": [
       "dom",

tsconfig.lib.prod.json

@@ -1,6 +1,7 @@
+/* To learn more about this file see: https://angular.io/config/tsconfig. */
 {
   "extends": "./tsconfig.lib.json",
   "angularCompilerOptions": {
     "enableIvy": false
   }
-}
+}

tsconfig.spec.json

@@ -3,8 +3,7 @@
   "compilerOptions": {
     "outDir": "./out-tsc/spec",
     "types": [
-      "jasmine",
-      "node"
+      "jasmine"
     ]
   },
   "files": [