deprecated=true attribute error

[neildes2]

My agent (v2.5) receives a bad ENUM for Execution. So I used a ruby script to transform it to a valid ENUM which is shown in the xml 'current' and sample observations correctly. The issue is that the deprecated attribute is being triggered prior to my ruby script correction. So even though the value is correct in the output, the deprecated attribute is being flagged.

If I don't use a ruby script , the deprecated flag works correctly.

ruby command for splice.
pipe.splice_before('DuplicateFilter', trans)

Shouldn't the deprecation check only happen AFTER all transforms?

Im transforming PROGRAM_OPTIONAL_STOP to OPTIONAL_STOP

[wsobel]

Please send me a copy of the script and the data coming through. I will replicate the problem. It may be in the ruby mapping and may need to be fixed. I'm traveling today, but I can evaluate tomorrow or on route.

Best
W

[wsobel]

The deprecation check occurs during the validation transform in 2.5 and marks the observation as deprecated if the value has been deprecated in a previous version.

I wonder if it is doing some additional validation on the observation. It may be the order of operations is causing the issue.

[wsobel]

Try splicing before Validator.

Validation is now before duplicate filtering. Maybe that should be reversed? What do you think?

[wsobel]

Current order

      // Validate Values
      if (IsOptionSet(m_options, configuration::Validation))
        next = next->bind(make_shared<Validator>(m_context));

      // Filter dups, by delta, and by period
      next = next->bind(make_shared<DuplicateFilter>(m_context));
      next = next->bind(make_shared<DeltaFilter>(m_context));
      next = next->bind(make_shared<PeriodFilter>(m_context, m_strand));

[neildes2]

putting the splice before the Validator worked as expected. Im thinking Validation should come last. The whole idea of the splices is to do transforms right? maybe a question for the EC, SC, or the Agent working group. Up to you where it should reside.

[wsobel]

Makes sense. I'll fix the order in the next release.

[wsobel]

Moved after all other transforms