add new line to debug dev after dumping body to debug dev

Author: Steven Liu

lib/httpclient.rb

@@ -1256,6 +1256,8 @@ def do_get_block(req, proxy, conn, &block)
         content << part
       end
     end
+    @debug_dev << "\n" if @debug_dev
+
     # there could be a race condition but it's OK to cache unreusable
     # connection because we do retry for that case.
     @session_manager.keep(sess) unless sess.closed?
@@ -1290,6 +1292,8 @@ def do_get_stream(req, proxy, conn)
       set_encoding(part, res.body_encoding)
       pipew.write(part)
     end
+    @debug_dev << "\n" if @debug_dev
+
     pipew.close
     @session_manager.keep(sess) unless sess.closed?
     _ = @request_filter.collect { |filter|

test/test_http-access2.rb

@@ -60,6 +60,15 @@ def test_debug_dev
     assert(!str.empty?)
   end
 
+  def test_debug_dev_shared_dev
+    str = "".dup
+    @client.debug_dev = str
+    @client.get(serverurl)
+    str << "another stuff\n"
+    lines = str.split(/(?:\r?\n)+/)
+    assert_equal('another stuff', lines[-1])
+  end
+
   def _test_protocol_version_http09
     @client.protocol_version = 'HTTP/0.9'
     str = "".dup

test/test_httpclient.rb

@@ -57,6 +57,18 @@ def test_debug_dev
     assert(!str.empty?)
   end
 
+  def test_debug_dev_shared_dev
+    str = "".dup
+    @client.debug_dev = str
+    @client.get(serverurl + 'hello')
+
+    str << "another stuff\n"
+    lines = str.split(/(?:\r?\n)+/)
+
+    assert_equal('hello', lines[-2])
+    assert_equal('another stuff', lines[-1])
+  end
+
   def test_debug_dev_stream
     str = "".dup
     @client.debug_dev = str
@@ -65,6 +77,18 @@ def test_debug_dev_stream
     assert(!str.empty?)
   end
 
+  def test_debug_dev_stream_shared_dev
+    str = "".dup
+    @client.debug_dev = str
+    conn = @client.get_async(serverurl)
+    Thread.pass while !conn.finished?
+
+    str << "another stuff\n"
+    lines = str.split(/(?:\r?\n)+/)
+
+    assert_equal('another stuff', lines[-1])
+  end
+
   def test_protocol_version_http09
     @client.protocol_version = 'HTTP/0.9'
     @client.debug_dev = str = ''.dup