From 48023d3384738ba69b79215cf9e326f55546f293 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Mon, 22 Jun 2026 14:46:34 +0200 Subject: [PATCH 1/6] Add actionlint workflow --- .github/workflows/actionlint.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/workflows/actionlint.yml diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml new file mode 100644 index 0000000..541b883 --- /dev/null +++ b/.github/workflows/actionlint.yml @@ -0,0 +1,21 @@ +name: Actionlint +# https://github.com/rhysd/actionlint + +on: + pull_request: + paths: + - '.github/**' + +jobs: + actionlint: + name: Action lint + runs-on: ubuntu-slim + steps: + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + with: + persist-credentials: false + - name: Check workflow files + run: | + bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) + ./actionlint -color -ignore SC2129 + shell: bash From eee949c5e850fc48a26bb93da91f13a95396a431 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Mon, 22 Jun 2026 15:01:10 +0200 Subject: [PATCH 2/6] initial fix of actionint problems --- .github/workflows/build_and_deploy.yml | 3 +-- .github/workflows/remove_ready_to_merge.yml | 1 + .github/workflows/upload_coverage.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index f3a2c04..e001e3c 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -13,7 +13,6 @@ on: target_directory: description: 'The directory to deploy the docs to' required: true - default: 'dev' type: string napari_ref: description: 'The napari/napari ref to build the docs against' @@ -31,7 +30,7 @@ concurrency: jobs: build-and-upload: name: Build & Upload Artifact - uses: .github/workflows/build_docs.yml + uses: ./.github/workflows/build_docs.yml secrets: inherit with: main-repo: "napari/napari" diff --git a/.github/workflows/remove_ready_to_merge.yml b/.github/workflows/remove_ready_to_merge.yml index 11fa8ef..5ed717e 100644 --- a/.github/workflows/remove_ready_to_merge.yml +++ b/.github/workflows/remove_ready_to_merge.yml @@ -7,6 +7,7 @@ on: description: 'The name of the label to remove from closed items' required: false default: 'ready to merge' + type: string permissions: pull-requests: write diff --git a/.github/workflows/upload_coverage.yml b/.github/workflows/upload_coverage.yml index 4831034..b8aabb9 100644 --- a/.github/workflows/upload_coverage.yml +++ b/.github/workflows/upload_coverage.yml @@ -70,7 +70,7 @@ jobs: python -Im coverage combine --rcfile=ci_coveragerc covreports python -Im coverage xml -o coverage.xml python -Im coverage report - python -Im coverage report --format=markdown --skip-empty --skip-covered >> $GITHUB_STEP_SUMMARY + python -Im coverage report --format=markdown --skip-empty --skip-covered >> "$GITHUB_STEP_SUMMARY" - name: Upload to codecov uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1 From 6a2df35c5c4be99aad65180a6f0f1335f42b9892 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Mon, 22 Jun 2026 15:06:48 +0200 Subject: [PATCH 3/6] trigger ci From 923e8104ca8900c7b37f4542da389dd78ac9602e Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Mon, 22 Jun 2026 15:09:19 +0200 Subject: [PATCH 4/6] fix SC2028 --- .github/workflows/upload_coverage.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/upload_coverage.yml b/.github/workflows/upload_coverage.yml index b8aabb9..27ede6d 100644 --- a/.github/workflows/upload_coverage.yml +++ b/.github/workflows/upload_coverage.yml @@ -56,12 +56,12 @@ jobs: # if src exists, add it to the pathmap if [ -d "src" ]; then echo " src/" >> ci_coveragerc - echo " D:\\a\\$REPO_NAME\\$REPO_NAME\\src" >> ci_coveragerc + printf '%s\n' " D:\\a\\$REPO_NAME\\$REPO_NAME\\src" >> ci_coveragerc echo " /home/runner/work/$REPO_NAME/$REPO_NAME/src" >> ci_coveragerc echo " /Users/runner/work/$REPO_NAME/$REPO_NAME/src" >> ci_coveragerc else echo " ${GITHUB_WORKSPACE}" >> ci_coveragerc - echo " D:\\a\\$REPO_NAME\\$REPO_NAME" >> ci_coveragerc + printf '%s\n' " D:\\a\\$REPO_NAME\\$REPO_NAME" >> ci_coveragerc echo " /home/runner/work/$REPO_NAME/$REPO_NAME" >> ci_coveragerc echo " /Users/runner/work/$REPO_NAME/$REPO_NAME" >> ci_coveragerc fi From d5e595395cc1620512f52f4e16ce5bb2c860721a Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Mon, 22 Jun 2026 15:37:12 +0200 Subject: [PATCH 5/6] set permisions to empty --- .github/workflows/actionlint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 541b883..a1ddddb 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -6,6 +6,8 @@ on: paths: - '.github/**' +permissions: {} + jobs: actionlint: name: Action lint From 5f60064d551b0c12c0dc910ff55ec4e7641d5634 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Wed, 24 Jun 2026 09:12:23 +0200 Subject: [PATCH 6/6] Apply suggestion from @Czaki --- .github/workflows/actionlint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index a1ddddb..e6bb7e3 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -4,7 +4,7 @@ name: Actionlint on: pull_request: paths: - - '.github/**' + - '.github/workflows/**' permissions: {}