Skip to content

Conversation

@FlorentinD
Copy link
Contributor

@FlorentinD FlorentinD commented Dec 5, 2025

  • move graphdatascience to src/graphdatascience (keep tests on root level)
  • setup.py & requirements -> pyproject.toml. This requires pip >= 25.0 to be installed in order to usepip install --group dev-base . f.i.

* move graphdatascience to src/graphdatascience (except for tets
* setup.py & requirements -> pyproject.toml
@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for neo4j-graph-data-science-client canceled.

Name Link
🔨 Latest commit 5989c2b
🔍 Latest deploy log https://app.netlify.com/projects/neo4j-graph-data-science-client/deploys/6936ff205d1ec000085fc1dd

@FlorentinD FlorentinD changed the title Remove setup.py in favor of pyproject.toml Merge setup.py into pyproject.toml Dec 5, 2025
Copy link
Contributor

@DarthMax DarthMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good afaiu, Seems there are still import issues

@FlorentinD
Copy link
Contributor Author

Looks good afaiu, Seems there are still import issues

i think its a tox version issue (older version not liking dependency-groups yet). updating the image now https://github.com/neo-technology/build-service-pipelines/pull/1680

with min version supporting dependency groups from toml
@FlorentinD FlorentinD merged commit 8115fe4 into neo4j:main Dec 8, 2025
7 checks passed
@FlorentinD FlorentinD deleted the gdsa-485-support-restructure-project branch December 8, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants